Re: [PATCH v2] regulator: wm8994: Don't use devres for enable GPIOs

2018-11-22 Thread Charles Keepax
On Thu, Nov 22, 2018 at 04:47:20PM +0100, Linus Walleij wrote: > On Thu, Nov 22, 2018 at 3:19 PM Linus Walleij > wrote: > > On Wed, Nov 21, 2018 at 11:13 AM Charles Keepax > > wrote: > > > > > The regulator core takes over managing the lifetime of the enable GPIO > > > once the regulator is regi

Re: [PATCH v2] regulator: wm8994: Don't use devres for enable GPIOs

2018-11-22 Thread Linus Walleij
On Thu, Nov 22, 2018 at 3:19 PM Linus Walleij wrote: > On Wed, Nov 21, 2018 at 11:13 AM Charles Keepax > wrote: > > > The regulator core takes over managing the lifetime of the enable GPIO > > once the regulator is registered. As such we shouldn't register the > > enable GPIO using devm, or it wi

Re: [PATCH v2] regulator: wm8994: Don't use devres for enable GPIOs

2018-11-22 Thread Linus Walleij
On Wed, Nov 21, 2018 at 11:42 AM Marek Szyprowski wrote: > Linus, Mark: Similar issue is probably in the other regulator drivers, > which use enable GPIO allocated by devm_gpio_get*(). This driver is > simply the first one, which we observed it. It would be great if one > would take a look into r

Re: [PATCH v2] regulator: wm8994: Don't use devres for enable GPIOs

2018-11-22 Thread Linus Walleij
On Wed, Nov 21, 2018 at 11:13 AM Charles Keepax wrote: > The regulator core takes over managing the lifetime of the enable GPIO > once the regulator is registered. As such we shouldn't register the > enable GPIO using devm, or it will be freed twice. > > Reported-by: Marek Szyprowski > Signed-of

Re: [PATCH v2] regulator: wm8994: Don't use devres for enable GPIOs

2018-11-21 Thread Charles Keepax
On Wed, Nov 21, 2018 at 11:42:06AM +0100, Marek Szyprowski wrote: > On 2018-11-21 11:13, Charles Keepax wrote: > Linus, Mark: Similar issue is probably in the other regulator drivers, > which use enable GPIO allocated by devm_gpio_get*(). This driver is > simply the first one, which we observed it.

Re: [PATCH v2] regulator: wm8994: Don't use devres for enable GPIOs

2018-11-21 Thread Marek Szyprowski
Hi Charles, On 2018-11-21 11:13, Charles Keepax wrote: > The regulator core takes over managing the lifetime of the enable GPIO > once the regulator is registered. As such we shouldn't register the > enable GPIO using devm, or it will be freed twice. > > Reported-by: Marek Szyprowski > Signed-off

[PATCH v2] regulator: wm8994: Don't use devres for enable GPIOs

2018-11-21 Thread Charles Keepax
The regulator core takes over managing the lifetime of the enable GPIO once the regulator is registered. As such we shouldn't register the enable GPIO using devm, or it will be freed twice. Reported-by: Marek Szyprowski Signed-off-by: Charles Keepax --- Again only build tested. Thanks, Charles