Re: [PATCH v2] rtc: add Abracon ABx80x driver

2015-03-04 Thread Philippe De Muyter
Hi Alexandre, On Wed, Mar 04, 2015 at 11:38:14AM +0100, Alexandre Belloni wrote: > On 04/03/2015 at 10:55:56 +0100, Philippe De Muyter wrote : > > > The "AB08XX Real-Time Clock Family" document states that they are all > > > software and pin compatible (including the AB18xx). > > > > Which

Re: [PATCH v2] rtc: add Abracon ABx80x driver

2015-03-04 Thread Alexandre Belloni
On 04/03/2015 at 10:55:56 +0100, Philippe De Muyter wrote : > > The "AB08XX Real-Time Clock Family" document states that they are all > > software and pin compatible (including the AB18xx). > > Which part(s) do you really have ? Mine is a 1805. Do all the parts have > the trickle charger ? As

Re: [PATCH v2] rtc: add Abracon ABx80x driver

2015-03-04 Thread Philippe De Muyter
Hi Alexandre, On Wed, Mar 04, 2015 at 10:06:01AM +0100, Alexandre Belloni wrote: > On 04/03/2015 at 09:52:42 +0100, Philippe De Muyter wrote : > > > > And is the naming in Philippe's driver appropriate? If it supports the > > > > AB1801 (for example) then why is it described as an "abx805"

Re: [PATCH v2] rtc: add Abracon ABx80x driver

2015-03-04 Thread Alexandre Belloni
On 04/03/2015 at 09:52:42 +0100, Philippe De Muyter wrote : > > > And is the naming in Philippe's driver appropriate? If it supports the > > > AB1801 (for example) then why is it described as an "abx805" driver? > > > > The real naming is in the form ABx8yz. With: > > > > x: 0 or 1, indicate

Re: [PATCH v2] rtc: add Abracon ABx80x driver

2015-03-04 Thread Philippe De Muyter
On Tue, Mar 03, 2015 at 09:50:32PM +0100, Alexandre Belloni wrote: > On 03/03/2015 at 12:20:12 -0800, Andrew Morton wrote : > > On Tue, 3 Mar 2015 02:11:16 +0100 Alexandre Belloni > > wrote: > > > > > On 02/03/2015 at 15:53:37 -0800, Andrew Morton wrote : > > > > On Sun, 1 Mar 2015 11:27:15

Re: [PATCH v2] rtc: add Abracon ABx80x driver

2015-03-04 Thread Alexandre Belloni
On 04/03/2015 at 09:52:42 +0100, Philippe De Muyter wrote : And is the naming in Philippe's driver appropriate? If it supports the AB1801 (for example) then why is it described as an abx805 driver? The real naming is in the form ABx8yz. With: x: 0 or 1, indicate the presence of

Re: [PATCH v2] rtc: add Abracon ABx80x driver

2015-03-04 Thread Philippe De Muyter
On Tue, Mar 03, 2015 at 09:50:32PM +0100, Alexandre Belloni wrote: On 03/03/2015 at 12:20:12 -0800, Andrew Morton wrote : On Tue, 3 Mar 2015 02:11:16 +0100 Alexandre Belloni alexandre.bell...@free-electrons.com wrote: On 02/03/2015 at 15:53:37 -0800, Andrew Morton wrote : On Sun,

Re: [PATCH v2] rtc: add Abracon ABx80x driver

2015-03-04 Thread Philippe De Muyter
Hi Alexandre, On Wed, Mar 04, 2015 at 10:06:01AM +0100, Alexandre Belloni wrote: On 04/03/2015 at 09:52:42 +0100, Philippe De Muyter wrote : And is the naming in Philippe's driver appropriate? If it supports the AB1801 (for example) then why is it described as an abx805 driver?

Re: [PATCH v2] rtc: add Abracon ABx80x driver

2015-03-04 Thread Alexandre Belloni
On 04/03/2015 at 10:55:56 +0100, Philippe De Muyter wrote : The AB08XX Real-Time Clock Family document states that they are all software and pin compatible (including the AB18xx). Which part(s) do you really have ? Mine is a 1805. Do all the parts have the trickle charger ? As I don't

Re: [PATCH v2] rtc: add Abracon ABx80x driver

2015-03-04 Thread Philippe De Muyter
Hi Alexandre, On Wed, Mar 04, 2015 at 11:38:14AM +0100, Alexandre Belloni wrote: On 04/03/2015 at 10:55:56 +0100, Philippe De Muyter wrote : The AB08XX Real-Time Clock Family document states that they are all software and pin compatible (including the AB18xx). Which part(s) do you

Re: [PATCH v2] rtc: add Abracon ABx80x driver

2015-03-03 Thread Alexandre Belloni
On 03/03/2015 at 14:32:07 -0800, Andrew Morton wrote : > On Tue, 3 Mar 2015 21:50:32 +0100 Alexandre Belloni > wrote: > > > To move forward, I can either send follow up patches based on what > > Philippe did. > > > > Or I can merge features from Philippe in my driver in a new patch, > >

Re: [PATCH v2] rtc: add Abracon ABx80x driver

2015-03-03 Thread Andrew Morton
On Tue, 3 Mar 2015 21:50:32 +0100 Alexandre Belloni wrote: > To move forward, I can either send follow up patches based on what > Philippe did. > > Or I can merge features from Philippe in my driver in a new patch, > keeping his authorship. I'm easy either way ;) I guess we could put

Re: [PATCH v2] rtc: add Abracon ABx80x driver

2015-03-03 Thread Alexandre Belloni
On 03/03/2015 at 12:20:12 -0800, Andrew Morton wrote : > On Tue, 3 Mar 2015 02:11:16 +0100 Alexandre Belloni > wrote: > > > On 02/03/2015 at 15:53:37 -0800, Andrew Morton wrote : > > > On Sun, 1 Mar 2015 11:27:15 +0100 Alexandre Belloni > > > wrote: > > > > > > > Add support for the i2c RTC

Re: [PATCH v2] rtc: add Abracon ABx80x driver

2015-03-03 Thread Andrew Morton
On Tue, 3 Mar 2015 02:11:16 +0100 Alexandre Belloni wrote: > On 02/03/2015 at 15:53:37 -0800, Andrew Morton wrote : > > On Sun, 1 Mar 2015 11:27:15 +0100 Alexandre Belloni > > wrote: > > > > > Add support for the i2c RTC from Abracon. > > > > What is the relationship between this patch and

Re: [PATCH v2] rtc: add Abracon ABx80x driver

2015-03-03 Thread Alexandre Belloni
On 03/03/2015 at 12:20:12 -0800, Andrew Morton wrote : On Tue, 3 Mar 2015 02:11:16 +0100 Alexandre Belloni alexandre.bell...@free-electrons.com wrote: On 02/03/2015 at 15:53:37 -0800, Andrew Morton wrote : On Sun, 1 Mar 2015 11:27:15 +0100 Alexandre Belloni

Re: [PATCH v2] rtc: add Abracon ABx80x driver

2015-03-03 Thread Andrew Morton
On Tue, 3 Mar 2015 02:11:16 +0100 Alexandre Belloni alexandre.bell...@free-electrons.com wrote: On 02/03/2015 at 15:53:37 -0800, Andrew Morton wrote : On Sun, 1 Mar 2015 11:27:15 +0100 Alexandre Belloni alexandre.bell...@free-electrons.com wrote: Add support for the i2c RTC from

Re: [PATCH v2] rtc: add Abracon ABx80x driver

2015-03-03 Thread Alexandre Belloni
On 03/03/2015 at 14:32:07 -0800, Andrew Morton wrote : On Tue, 3 Mar 2015 21:50:32 +0100 Alexandre Belloni alexandre.bell...@free-electrons.com wrote: To move forward, I can either send follow up patches based on what Philippe did. Or I can merge features from Philippe in my driver

Re: [PATCH v2] rtc: add Abracon ABx80x driver

2015-03-03 Thread Andrew Morton
On Tue, 3 Mar 2015 21:50:32 +0100 Alexandre Belloni alexandre.bell...@free-electrons.com wrote: To move forward, I can either send follow up patches based on what Philippe did. Or I can merge features from Philippe in my driver in a new patch, keeping his authorship. I'm easy either way

Re: [PATCH v2] rtc: add Abracon ABx80x driver

2015-03-02 Thread Alexandre Belloni
On 02/03/2015 at 15:53:37 -0800, Andrew Morton wrote : > On Sun, 1 Mar 2015 11:27:15 +0100 Alexandre Belloni > wrote: > > > Add support for the i2c RTC from Abracon. > > What is the relationship between this patch and >

Re: [PATCH v2] rtc: add Abracon ABx80x driver

2015-03-02 Thread Andrew Morton
On Sun, 1 Mar 2015 11:27:15 +0100 Alexandre Belloni wrote: > Add support for the i2c RTC from Abracon. What is the relationship between this patch and http://ozlabs.org/~akpm/mmots/broken-out/rtc-add-rtc-abx805-a-driver-for-the-abracon-ab-1805-i2c-rtc.patch? From: Alexandre Belloni

Re: [PATCH v2] rtc: add Abracon ABx80x driver

2015-03-02 Thread Paul Bolle
On Sun, 2015-03-01 at 11:27 +0100, Alexandre Belloni wrote: > --- /dev/null > +++ b/drivers/rtc/rtc-abx80x.c > @@ -0,0 +1,193 @@ > +/* > + * An I2C driver for the Abracon AB08xx > + * > + * Author: Alexandre Belloni > + * > + * This program is free software; you can redistribute it and/or modify

Re: [PATCH v2] rtc: add Abracon ABx80x driver

2015-03-02 Thread Andrew Morton
On Sun, 1 Mar 2015 11:27:15 +0100 Alexandre Belloni alexandre.bell...@free-electrons.com wrote: Add support for the i2c RTC from Abracon. What is the relationship between this patch and http://ozlabs.org/~akpm/mmots/broken-out/rtc-add-rtc-abx805-a-driver-for-the-abracon-ab-1805-i2c-rtc.patch?

Re: [PATCH v2] rtc: add Abracon ABx80x driver

2015-03-02 Thread Alexandre Belloni
On 02/03/2015 at 15:53:37 -0800, Andrew Morton wrote : On Sun, 1 Mar 2015 11:27:15 +0100 Alexandre Belloni alexandre.bell...@free-electrons.com wrote: Add support for the i2c RTC from Abracon. What is the relationship between this patch and

Re: [PATCH v2] rtc: add Abracon ABx80x driver

2015-03-02 Thread Paul Bolle
On Sun, 2015-03-01 at 11:27 +0100, Alexandre Belloni wrote: --- /dev/null +++ b/drivers/rtc/rtc-abx80x.c @@ -0,0 +1,193 @@ +/* + * An I2C driver for the Abracon AB08xx + * + * Author: Alexandre Belloni alexandre.bell...@free-electrons.com + * + * This program is free software; you can

[PATCH v2] rtc: add Abracon ABx80x driver

2015-03-01 Thread Alexandre Belloni
Add support for the i2c RTC from Abracon. Signed-off-by: Alexandre Belloni --- Changes in v2: - corrected style according to checkpatch --strict - renamed functions to abx80x_* - reordered makefile and kconfig additions drivers/rtc/Kconfig | 9 +++ drivers/rtc/Makefile | 1 +

[PATCH v2] rtc: add Abracon ABx80x driver

2015-03-01 Thread Alexandre Belloni
Add support for the i2c RTC from Abracon. Signed-off-by: Alexandre Belloni alexandre.bell...@free-electrons.com --- Changes in v2: - corrected style according to checkpatch --strict - renamed functions to abx80x_* - reordered makefile and kconfig additions drivers/rtc/Kconfig | 9 +++