Re: [PATCH v2] rtl8xxxu: add bluetooth co-existence support for single antenna

2019-10-04 Thread Jes Sorensen
On 10/2/19 9:19 PM, Chris Chiu wrote: On Wed, Oct 2, 2019 at 11:04 PM Jes Sorensen wrote: In general I think it looks good! One nit below: Sorry I have been traveling for the last three weeks, so just catching up. +void rtl8723bu_set_coex_with_type(struct rtl8xxxu_priv *priv, u8 type) +{

Re: [PATCH v2] rtl8xxxu: add bluetooth co-existence support for single antenna

2019-10-02 Thread Chris Chiu
On Wed, Oct 2, 2019 at 11:04 PM Jes Sorensen wrote: > > > In general I think it looks good! One nit below: > > Sorry I have been traveling for the last three weeks, so just catching up. > > > > +void rtl8723bu_set_coex_with_type(struct rtl8xxxu_priv *priv, u8 type) > > +{ > > + switch (type)

Re: [PATCH v2] rtl8xxxu: add bluetooth co-existence support for single antenna

2019-10-02 Thread Kalle Valo
Chris Chiu writes: > On Wed, Oct 2, 2019 at 12:29 PM Kalle Valo wrote: > >> Failed to apply, please rebase on top of wireless-drivers-next. >> >> fatal: sha1 information is lacking or useless >> (drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h). >> error: could not build fake ancestor >>

Re: [PATCH v2] rtl8xxxu: add bluetooth co-existence support for single antenna

2019-10-02 Thread Jes Sorensen
On 9/10/19 10:50 PM, Chris Chiu wrote: The RTL8723BU suffers the wifi disconnection problem while bluetooth device connected. While wifi is doing tx/rx, the bluetooth will scan without results. This is due to the wifi and bluetooth share the same single antenna for RF communication and they need

Re: [PATCH v2] rtl8xxxu: add bluetooth co-existence support for single antenna

2019-10-02 Thread Chris Chiu
On Wed, Oct 2, 2019 at 12:29 PM Kalle Valo wrote: > Failed to apply, please rebase on top of wireless-drivers-next. > > fatal: sha1 information is lacking or useless > (drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h). > error: could not build fake ancestor > Applying: rtl8xxxu: add bluetooth

Re: [PATCH v2] rtl8xxxu: add bluetooth co-existence support for single antenna

2019-10-01 Thread Kalle Valo
Chris Chiu wrote: > The RTL8723BU suffers the wifi disconnection problem while bluetooth > device connected. While wifi is doing tx/rx, the bluetooth will scan > without results. This is due to the wifi and bluetooth share the same > single antenna for RF communication and they need to have a

Re: [PATCH v2] rtl8xxxu: add bluetooth co-existence support for single antenna

2019-10-01 Thread Kalle Valo
Chris Chiu wrote: > The RTL8723BU suffers the wifi disconnection problem while bluetooth > device connected. While wifi is doing tx/rx, the bluetooth will scan > without results. This is due to the wifi and bluetooth share the same > single antenna for RF communication and they need to have a

Re: [PATCH v2] rtl8xxxu: add bluetooth co-existence support for single antenna

2019-10-01 Thread Chris Chiu
On Thu, Sep 19, 2019 at 9:44 AM Chris Chiu wrote: > > On Wed, Sep 11, 2019 at 10:50 AM Chris Chiu wrote: > > > > > > Notes: > > v2: > >- Add helper functions to replace bunch of tdma settings > >- Reformat some lines to meet kernel coding style > > > > > Hi Jes, I've refactored the

Re: [PATCH v2] rtl8xxxu: add bluetooth co-existence support for single antenna

2019-09-18 Thread Chris Chiu
On Wed, Sep 11, 2019 at 10:50 AM Chris Chiu wrote: > > > Notes: > v2: >- Add helper functions to replace bunch of tdma settings >- Reformat some lines to meet kernel coding style > > Gentle ping. Any suggestions would be appreciated. Thanks. Chris

[PATCH v2] rtl8xxxu: add bluetooth co-existence support for single antenna

2019-09-10 Thread Chris Chiu
The RTL8723BU suffers the wifi disconnection problem while bluetooth device connected. While wifi is doing tx/rx, the bluetooth will scan without results. This is due to the wifi and bluetooth share the same single antenna for RF communication and they need to have a mechanism to collaborate. BT