Re: [PATCH v2] rtmutex: take the waiter lock with irqs off

2013-11-25 Thread Paul Gortmaker
On 13-11-22 11:08 AM, Peter Zijlstra wrote: > On Fri, Nov 22, 2013 at 02:59:31PM +0100, Sebastian Andrzej Siewior wrote: >> +extern void __lockfunc rt_spin_try_unlock(spinlock_t *lock); > > I know what you mean, but.. try_unlock() just sounds wrong, how can we > attempt but fail to unlock a lock w

Re: [PATCH v2] rtmutex: take the waiter lock with irqs off

2013-11-22 Thread Sebastian Andrzej Siewior
On 11/22/2013 05:21 PM, Sebastian Andrzej Siewior wrote: > On 11/22/2013 05:08 PM, Peter Zijlstra wrote: >> On Fri, Nov 22, 2013 at 02:59:31PM +0100, Sebastian Andrzej Siewior wrote: >>> +extern void __lockfunc rt_spin_try_unlock(spinlock_t *lock); >> >> I know what you mean, but.. try_unlock() jus

Re: [PATCH v2] rtmutex: take the waiter lock with irqs off

2013-11-22 Thread Sebastian Andrzej Siewior
On 11/22/2013 05:08 PM, Peter Zijlstra wrote: > On Fri, Nov 22, 2013 at 02:59:31PM +0100, Sebastian Andrzej Siewior wrote: >> +extern void __lockfunc rt_spin_try_unlock(spinlock_t *lock); > > I know what you mean, but.. try_unlock() just sounds wrong, how can we > attempt but fail to unlock a lock

Re: [PATCH v2] rtmutex: take the waiter lock with irqs off

2013-11-22 Thread Peter Zijlstra
On Fri, Nov 22, 2013 at 02:59:31PM +0100, Sebastian Andrzej Siewior wrote: > +extern void __lockfunc rt_spin_try_unlock(spinlock_t *lock); I know what you mean, but.. try_unlock() just sounds wrong, how can we attempt but fail to unlock a lock we hold ;-) /me crawls back under his rock ;-) -- To

Re: [PATCH v2] rtmutex: take the waiter lock with irqs off

2013-11-22 Thread Sebastian Andrzej Siewior
* Peter Zijlstra | 2013-11-18 15:10:21 [+0100]: >Its get_next_timer_interrupt() that does a trylock() and only for >PREEMPT_RT_FULL. > >Also; on IRC you said: > > " I'm currently not sure if we should do >the _irq() lock or a trylock for the wait_lock in >rt_mutex_slowtrylock()" > >Which I misrea

Re: [PATCH v2] rtmutex: take the waiter lock with irqs off

2013-11-19 Thread Peter Zijlstra
On Tue, Nov 19, 2013 at 12:59:59AM +0100, Frederic Weisbecker wrote: > On Mon, Nov 18, 2013 at 03:10:21PM +0100, Peter Zijlstra wrote: > > --- a/kernel/softirq.c > > +++ b/kernel/softirq.c > > @@ -746,13 +746,23 @@ void irq_exit(void) > > #endif > > > > account_irq_exit_time(current); > > -

Re: [PATCH v2] rtmutex: take the waiter lock with irqs off

2013-11-18 Thread Frederic Weisbecker
On Mon, Nov 18, 2013 at 03:10:21PM +0100, Peter Zijlstra wrote: > --- a/kernel/softirq.c > +++ b/kernel/softirq.c > @@ -746,13 +746,23 @@ void irq_exit(void) > #endif > > account_irq_exit_time(current); > - trace_hardirq_exit(); > sub_preempt_count(HARDIRQ_OFFSET); > - if (!i

Re: [PATCH v2] rtmutex: take the waiter lock with irqs off

2013-11-18 Thread Peter Zijlstra
On Mon, Nov 18, 2013 at 03:10:21PM +0100, Peter Zijlstra wrote: > --- a/kernel/softirq.c > +++ b/kernel/softirq.c > @@ -746,13 +746,23 @@ void irq_exit(void) > #endif > > account_irq_exit_time(current); > - trace_hardirq_exit(); > sub_preempt_count(HARDIRQ_OFFSET); > - if (!i

Re: [PATCH v2] rtmutex: take the waiter lock with irqs off

2013-11-18 Thread Peter Zijlstra
On Fri, Nov 15, 2013 at 09:14:36PM +0100, Sebastian Andrzej Siewior wrote: > Mike Galbraith captered the following: > | >#11 [88017b243e90] _raw_spin_lock at 815d2596 > | >#12 [88017b243e90] rt_mutex_trylock at 815d15be > | >#13 [88017b243eb0] get_next_timer_interrupt at

[PATCH v2] rtmutex: take the waiter lock with irqs off

2013-11-15 Thread Sebastian Andrzej Siewior
Mike Galbraith captered the following: | >#11 [88017b243e90] _raw_spin_lock at 815d2596 | >#12 [88017b243e90] rt_mutex_trylock at 815d15be | >#13 [88017b243eb0] get_next_timer_interrupt at 81063b42 | >#14 [88017b243f00] tick_nohz_stop_sched_tick at 81