Re: [PATCH v2] sched/core: silence a warning in sched_init()

2019-07-18 Thread Qian Cai
> On Jun 25, 2019, at 11:57 AM, Peter Zijlstra wrote: > > On Tue, Jun 25, 2019 at 11:07:09AM -0400, Qian Cai wrote: >> On Tue, 2019-06-25 at 16:25 +0200, Peter Zijlstra wrote: >>> On Tue, Jun 25, 2019 at 10:04:19AM -0400, Qian Cai wrote: On Tue, 2019-06-25 at 15:52 +0200, Peter Zijlstra

Re: [PATCH v2] sched/core: silence a warning in sched_init()

2019-07-08 Thread Qian Cai
Ping. Per discussion, sounds like this is the best thing to do in order to avoid compilation warnings. On Tue, 2019-06-25 at 08:44 -0400, Qian Cai wrote: > Compiling a kernel with both FAIR_GROUP_SCHED=n and RT_GROUP_SCHED=n > will generate a warning using W=1, > > kernel/sched/core.c: In

Re: [PATCH v2] sched/core: silence a warning in sched_init()

2019-06-25 Thread Peter Zijlstra
On Tue, Jun 25, 2019 at 11:07:09AM -0400, Qian Cai wrote: > On Tue, 2019-06-25 at 16:25 +0200, Peter Zijlstra wrote: > > On Tue, Jun 25, 2019 at 10:04:19AM -0400, Qian Cai wrote: > > > On Tue, 2019-06-25 at 15:52 +0200, Peter Zijlstra wrote: > > > Yes, -Wmissing-prototype makes no sense, but

Re: [PATCH v2] sched/core: silence a warning in sched_init()

2019-06-25 Thread Qian Cai
On Tue, 2019-06-25 at 16:25 +0200, Peter Zijlstra wrote: > On Tue, Jun 25, 2019 at 10:04:19AM -0400, Qian Cai wrote: > > On Tue, 2019-06-25 at 15:52 +0200, Peter Zijlstra wrote: > > Yes, -Wmissing-prototype makes no sense, but "-Wunused-but-set-variable" is > > pretty valid to catch certain

Re: [PATCH v2] sched/core: silence a warning in sched_init()

2019-06-25 Thread Peter Zijlstra
On Tue, Jun 25, 2019 at 10:04:19AM -0400, Qian Cai wrote: > On Tue, 2019-06-25 at 15:52 +0200, Peter Zijlstra wrote: > Yes, -Wmissing-prototype makes no sense, but "-Wunused-but-set-variable" is > pretty valid to catch certain developer errors. For example, > >

Re: [PATCH v2] sched/core: silence a warning in sched_init()

2019-06-25 Thread Qian Cai
On Tue, 2019-06-25 at 15:52 +0200, Peter Zijlstra wrote: > On Tue, Jun 25, 2019 at 08:44:22AM -0400, Qian Cai wrote: > > Compiling a kernel with both FAIR_GROUP_SCHED=n and RT_GROUP_SCHED=n > > will generate a warning using W=1, > > > > kernel/sched/core.c: In function 'sched_init': > >

Re: [PATCH v2] sched/core: silence a warning in sched_init()

2019-06-25 Thread Peter Zijlstra
On Tue, Jun 25, 2019 at 08:44:22AM -0400, Qian Cai wrote: > Compiling a kernel with both FAIR_GROUP_SCHED=n and RT_GROUP_SCHED=n > will generate a warning using W=1, > > kernel/sched/core.c: In function 'sched_init': > kernel/sched/core.c:5906:32: warning: variable 'ptr' set but not used >

[PATCH v2] sched/core: silence a warning in sched_init()

2019-06-25 Thread Qian Cai
Compiling a kernel with both FAIR_GROUP_SCHED=n and RT_GROUP_SCHED=n will generate a warning using W=1, kernel/sched/core.c: In function 'sched_init': kernel/sched/core.c:5906:32: warning: variable 'ptr' set but not used [-Wunused-but-set-variable] unsigned long alloc_size = 0, ptr;