Re: [PATCH v2] sched/fair: Fix enqueue_task_fair warning some more

2020-05-12 Thread Peter Zijlstra
On Mon, May 11, 2020 at 04:44:10PM -0400, Phil Auld wrote: > Peter/Ingo, do you want me to resend or can you fix when applying? I now have this, do I need more edits? --- Subject: sched/fair: Fix enqueue_task_fair warning some more From: Phil Auld Date: Thu, 7 May 2020 16:36:12 -0400 From: Phi

Re: [PATCH v2] sched/fair: Fix enqueue_task_fair warning some more

2020-05-12 Thread Phil Auld
Hi Dietmar, On Tue, May 12, 2020 at 11:00:16AM +0200 Dietmar Eggemann wrote: > On 11/05/2020 22:44, Phil Auld wrote: > > On Mon, May 11, 2020 at 09:25:43PM +0200 Vincent Guittot wrote: > >> On Thu, 7 May 2020 at 22:36, Phil Auld wrote: > >>> > >>> sched/fair: Fix enqueue_task_fair warning some mo

Re: [PATCH v2] sched/fair: Fix enqueue_task_fair warning some more

2020-05-12 Thread Dietmar Eggemann
On 11/05/2020 22:44, Phil Auld wrote: > On Mon, May 11, 2020 at 09:25:43PM +0200 Vincent Guittot wrote: >> On Thu, 7 May 2020 at 22:36, Phil Auld wrote: >>> >>> sched/fair: Fix enqueue_task_fair warning some more >>> >>> The recent patch, fe61468b2cb (sched/fair: Fix enqueue_task_fair warning) >>>

Re: [PATCH v2] sched/fair: Fix enqueue_task_fair warning some more

2020-05-11 Thread Phil Auld
On Mon, May 11, 2020 at 09:25:43PM +0200 Vincent Guittot wrote: > On Thu, 7 May 2020 at 22:36, Phil Auld wrote: > > > > sched/fair: Fix enqueue_task_fair warning some more > > > > The recent patch, fe61468b2cb (sched/fair: Fix enqueue_task_fair warning) > > did not fully resolve the issues with th

Re: [PATCH v2] sched/fair: Fix enqueue_task_fair warning some more

2020-05-11 Thread Vincent Guittot
On Thu, 7 May 2020 at 22:36, Phil Auld wrote: > > sched/fair: Fix enqueue_task_fair warning some more > > The recent patch, fe61468b2cb (sched/fair: Fix enqueue_task_fair warning) > did not fully resolve the issues with the rq->tmp_alone_branch != > &rq->leaf_cfs_rq_list warning in enqueue_task_fa

Re: [PATCH v2] sched/fair: Fix enqueue_task_fair warning some more

2020-05-11 Thread Vincent Guittot
On Mon, 11 May 2020 at 17:13, Tao Zhou wrote: > > Hi Vincent, > > On Mon, May 11, 2020 at 10:36:43AM +0200, Vincent Guittot wrote: > > Hi Tao, > > > > On Fri, 8 May 2020 at 18:58, Tao Zhou wrote: > > > > > > On Fri, May 08, 2020 at 05:27:44PM +0200, Vincent Guittot wrote: > > > > On Fri, 8 May 20

Re: [PATCH v2] sched/fair: Fix enqueue_task_fair warning some more

2020-05-11 Thread Vincent Guittot
On Mon, 11 May 2020 at 19:02, Dietmar Eggemann wrote: > > On 11/05/2020 14:12, Vincent Guittot wrote: > > On Mon, 11 May 2020 at 12:39, Dietmar Eggemann > > wrote: > >> > >> On 11/05/2020 11:36, Vincent Guittot wrote: > >>> On Mon, 11 May 2020 at 10:40, Dietmar Eggemann > >>> wrote: > > >

Re: [PATCH v2] sched/fair: Fix enqueue_task_fair warning some more

2020-05-11 Thread Dietmar Eggemann
Hi Tao, On 11/05/2020 17:44, Tao Zhou wrote: > Hi Dietmar, [...] > On Mon, May 11, 2020 at 12:39:52PM +0200, Dietmar Eggemann wrote: >> On 11/05/2020 11:36, Vincent Guittot wrote: >>> On Mon, 11 May 2020 at 10:40, Dietmar Eggemann >>> wrote: On 08/05/2020 19:02, Tao Zhou wrote: >

Re: [PATCH v2] sched/fair: Fix enqueue_task_fair warning some more

2020-05-11 Thread Dietmar Eggemann
On 11/05/2020 14:12, Vincent Guittot wrote: > On Mon, 11 May 2020 at 12:39, Dietmar Eggemann > wrote: >> >> On 11/05/2020 11:36, Vincent Guittot wrote: >>> On Mon, 11 May 2020 at 10:40, Dietmar Eggemann >>> wrote: On 08/05/2020 19:02, Tao Zhou wrote: > On Fri, May 08, 2020 at 05:2

Re: [PATCH v2] sched/fair: Fix enqueue_task_fair warning some more

2020-05-11 Thread Vincent Guittot
On Mon, 11 May 2020 at 12:39, Dietmar Eggemann wrote: > > On 11/05/2020 11:36, Vincent Guittot wrote: > > On Mon, 11 May 2020 at 10:40, Dietmar Eggemann > > wrote: > >> > >> On 08/05/2020 19:02, Tao Zhou wrote: > >>> On Fri, May 08, 2020 at 05:27:44PM +0200, Vincent Guittot wrote: > On Fri,

Re: [PATCH v2] sched/fair: Fix enqueue_task_fair warning some more

2020-05-11 Thread Dietmar Eggemann
On 11/05/2020 11:36, Vincent Guittot wrote: > On Mon, 11 May 2020 at 10:40, Dietmar Eggemann > wrote: >> >> On 08/05/2020 19:02, Tao Zhou wrote: >>> On Fri, May 08, 2020 at 05:27:44PM +0200, Vincent Guittot wrote: On Fri, 8 May 2020 at 17:12, Tao Zhou wrote: > > Hi Phil, > >

Re: [PATCH v2] sched/fair: Fix enqueue_task_fair warning some more

2020-05-11 Thread Vincent Guittot
On Mon, 11 May 2020 at 10:40, Dietmar Eggemann wrote: > > On 08/05/2020 19:02, Tao Zhou wrote: > > On Fri, May 08, 2020 at 05:27:44PM +0200, Vincent Guittot wrote: > >> On Fri, 8 May 2020 at 17:12, Tao Zhou wrote: > >>> > >>> Hi Phil, > >>> > >>> On Thu, May 07, 2020 at 04:36:12PM -0400, Phil Aul

Re: [PATCH v2] sched/fair: Fix enqueue_task_fair warning some more

2020-05-11 Thread Dietmar Eggemann
On 08/05/2020 19:02, Tao Zhou wrote: > On Fri, May 08, 2020 at 05:27:44PM +0200, Vincent Guittot wrote: >> On Fri, 8 May 2020 at 17:12, Tao Zhou wrote: >>> >>> Hi Phil, >>> >>> On Thu, May 07, 2020 at 04:36:12PM -0400, Phil Auld wrote: sched/fair: Fix enqueue_task_fair warning some more [...

Re: [PATCH v2] sched/fair: Fix enqueue_task_fair warning some more

2020-05-11 Thread Vincent Guittot
Hi Tao, On Fri, 8 May 2020 at 18:58, Tao Zhou wrote: > > On Fri, May 08, 2020 at 05:27:44PM +0200, Vincent Guittot wrote: > > On Fri, 8 May 2020 at 17:12, Tao Zhou wrote: > > > > > > Hi Phil, > > > > > > On Thu, May 07, 2020 at 04:36:12PM -0400, Phil Auld wrote: > > > > sched/fair: Fix enqueue_t

Re: [PATCH v2] sched/fair: Fix enqueue_task_fair warning some more

2020-05-08 Thread Tao Zhou
On Fri, May 08, 2020 at 05:27:44PM +0200, Vincent Guittot wrote: > On Fri, 8 May 2020 at 17:12, Tao Zhou wrote: > > > > Hi Phil, > > > > On Thu, May 07, 2020 at 04:36:12PM -0400, Phil Auld wrote: > > > sched/fair: Fix enqueue_task_fair warning some more > > > > > > The recent patch, fe61468b2cb (s

Re: [PATCH v2] sched/fair: Fix enqueue_task_fair warning some more

2020-05-08 Thread Tao Zhou
Hi Phil, On Thu, May 07, 2020 at 04:36:12PM -0400, Phil Auld wrote: > sched/fair: Fix enqueue_task_fair warning some more > > The recent patch, fe61468b2cb (sched/fair: Fix enqueue_task_fair warning) > did not fully resolve the issues with the rq->tmp_alone_branch != > &rq->leaf_cfs_rq_list warni

Re: [PATCH v2] sched/fair: Fix enqueue_task_fair warning some more

2020-05-08 Thread Vincent Guittot
On Fri, 8 May 2020 at 17:12, Tao Zhou wrote: > > Hi Phil, > > On Thu, May 07, 2020 at 04:36:12PM -0400, Phil Auld wrote: > > sched/fair: Fix enqueue_task_fair warning some more > > > > The recent patch, fe61468b2cb (sched/fair: Fix enqueue_task_fair warning) > > did not fully resolve the issues wi

Re: [PATCH v2] sched/fair: Fix enqueue_task_fair warning some more

2020-05-07 Thread Phil Auld
sched/fair: Fix enqueue_task_fair warning some more The recent patch, fe61468b2cb (sched/fair: Fix enqueue_task_fair warning) did not fully resolve the issues with the rq->tmp_alone_branch != &rq->leaf_cfs_rq_list warning in enqueue_task_fair. There is a case where the first for_each_sched_entity