Re: [PATCH v2] sched/fair: enqueue_task_fair optimization

2020-05-13 Thread Phil Auld
On Wed, May 13, 2020 at 03:25:29PM +0200 Vincent Guittot wrote: > On Wed, 13 May 2020 at 15:18, Phil Auld wrote: > > > > On Wed, May 13, 2020 at 03:15:53PM +0200 Vincent Guittot wrote: > > > On Wed, 13 May 2020 at 15:13, Phil Auld wrote: > > > > > > > > On Wed, May 13, 2020 at 03:10:28PM +0200

Re: [PATCH v2] sched/fair: enqueue_task_fair optimization

2020-05-13 Thread Vincent Guittot
On Wed, 13 May 2020 at 15:18, Phil Auld wrote: > > On Wed, May 13, 2020 at 03:15:53PM +0200 Vincent Guittot wrote: > > On Wed, 13 May 2020 at 15:13, Phil Auld wrote: > > > > > > On Wed, May 13, 2020 at 03:10:28PM +0200 Vincent Guittot wrote: > > > > On Wed, 13 May 2020 at 14:45, Phil Auld

Re: [PATCH v2] sched/fair: enqueue_task_fair optimization

2020-05-13 Thread Phil Auld
On Wed, May 13, 2020 at 03:15:53PM +0200 Vincent Guittot wrote: > On Wed, 13 May 2020 at 15:13, Phil Auld wrote: > > > > On Wed, May 13, 2020 at 03:10:28PM +0200 Vincent Guittot wrote: > > > On Wed, 13 May 2020 at 14:45, Phil Auld wrote: > > > > > > > > Hi Vincent, > > > > > > > > On Wed, May

Re: [PATCH v2] sched/fair: enqueue_task_fair optimization

2020-05-13 Thread Vincent Guittot
On Wed, 13 May 2020 at 15:13, Phil Auld wrote: > > On Wed, May 13, 2020 at 03:10:28PM +0200 Vincent Guittot wrote: > > On Wed, 13 May 2020 at 14:45, Phil Auld wrote: > > > > > > Hi Vincent, > > > > > > On Wed, May 13, 2020 at 02:33:35PM +0200 Vincent Guittot wrote: > > > > enqueue_task_fair

Re: [PATCH v2] sched/fair: enqueue_task_fair optimization

2020-05-13 Thread Phil Auld
On Wed, May 13, 2020 at 03:10:28PM +0200 Vincent Guittot wrote: > On Wed, 13 May 2020 at 14:45, Phil Auld wrote: > > > > Hi Vincent, > > > > On Wed, May 13, 2020 at 02:33:35PM +0200 Vincent Guittot wrote: > > > enqueue_task_fair jumps to enqueue_throttle label when cfs_rq_of(se) is > > >

Re: [PATCH v2] sched/fair: enqueue_task_fair optimization

2020-05-13 Thread Vincent Guittot
On Wed, 13 May 2020 at 14:45, Phil Auld wrote: > > Hi Vincent, > > On Wed, May 13, 2020 at 02:33:35PM +0200 Vincent Guittot wrote: > > enqueue_task_fair jumps to enqueue_throttle label when cfs_rq_of(se) is > > throttled which means that se can't be NULL and we can skip the test. > > > > s/be

Re: [PATCH v2] sched/fair: enqueue_task_fair optimization

2020-05-13 Thread Phil Auld
Hi Vincent, On Wed, May 13, 2020 at 02:33:35PM +0200 Vincent Guittot wrote: > enqueue_task_fair jumps to enqueue_throttle label when cfs_rq_of(se) is > throttled which means that se can't be NULL and we can skip the test. > s/be NULL/be non-NULL/ I think. It's more like if it doesn't jump to

[PATCH v2] sched/fair: enqueue_task_fair optimization

2020-05-13 Thread Vincent Guittot
enqueue_task_fair jumps to enqueue_throttle label when cfs_rq_of(se) is throttled which means that se can't be NULL and we can skip the test. Reviewed-by: Phil Auld Signed-off-by: Vincent Guittot --- v2 changes: - Remove useless if statement kernel/sched/fair.c | 39