Re: [PATCH v2] sched: Fix broken setscheduler()

2014-03-11 Thread Thomas Gleixner
On Tue, 11 Mar 2014, Juri Lelli wrote: > On Mon, 10 Mar 2014 17:37:31 -0400 > Steven Rostedt wrote: > > > On Mon, 10 Mar 2014 22:18:56 +0100 (CET) > > Thomas Gleixner wrote: > > > > > > > Lemme look at it tomorrow again with an awake brain. This seems to be > > > some forward porting hickup wh

Re: [PATCH v2] sched: Fix broken setscheduler()

2014-03-11 Thread Juri Lelli
On Mon, 10 Mar 2014 17:37:31 -0400 Steven Rostedt wrote: > On Mon, 10 Mar 2014 22:18:56 +0100 (CET) > Thomas Gleixner wrote: > > > > Lemme look at it tomorrow again with an awake brain. This seems to be > > some forward porting hickup which needs a closer look. Just look at > > Yep, I talked

Re: [PATCH v2] sched: Fix broken setscheduler()

2014-03-10 Thread Steven Rostedt
On Mon, 10 Mar 2014 22:18:56 +0100 (CET) Thomas Gleixner wrote: > Lemme look at it tomorrow again with an awake brain. This seems to be > some forward porting hickup which needs a closer look. Just look at Yep, I talked with Sebastian on IRC and that seems to be the case. > the 3.10-rt version

Re: [PATCH v2] sched: Fix broken setscheduler()

2014-03-10 Thread Thomas Gleixner
On Mon, 10 Mar 2014, Steven Rostedt wrote: > On Thu, 6 Mar 2014 21:43:50 +0100 (CET) > Thomas Gleixner wrote: > > > > Reading what the commit is suppose to do, I realize that the p->prio > > > can't be set if the task is boosted with a higher prio, but the > > > p->normal_prio still needs to be

Re: [PATCH v2] sched: Fix broken setscheduler()

2014-03-10 Thread Steven Rostedt
On Thu, 6 Mar 2014 21:43:50 +0100 (CET) Thomas Gleixner wrote: > > Reading what the commit is suppose to do, I realize that the p->prio > > can't be set if the task is boosted with a higher prio, but the > > p->normal_prio still needs to be set regardless, otherwise, when the > > task is deboost

Re: [PATCH v2] sched: Fix broken setscheduler()

2014-03-06 Thread Thomas Gleixner
On Thu, 6 Mar 2014, Steven Rostedt wrote: > On Thu, 6 Mar 2014 13:20:40 +0100 > Juri Lelli wrote: > > > Yes. I think you can go with > > > > p->prio = p->normal_prio > > > > and save a few checks in rt_mutex_getprio(). > > > > You're right! Thanks. > > - > > I decided to run my tests

[PATCH v2] sched: Fix broken setscheduler()

2014-03-06 Thread Steven Rostedt
On Thu, 6 Mar 2014 13:20:40 +0100 Juri Lelli wrote: > Yes. I think you can go with > > p->prio = p->normal_prio > > and save a few checks in rt_mutex_getprio(). > You're right! Thanks. - I decided to run my tests on linux-next, and my wakeup_rt tracer was broken. After running a bisect