Re: [PATCH v2] sched: check user input value of sysctl_sched_time_avg

2017-09-06 Thread Ethan Zhao
On 2017/9/7 3:50, Luis R. Rodriguez wrote: On Mon, Sep 04, 2017 at 03:54:23PM +0800, Ethan Zhao wrote: Peter, On 2017/9/4 15:49, Peter Zijlstra wrote: On Sat, Sep 02, 2017 at 02:57:32PM +0800, Ethan Zhao wrote: diff --git a/kernel/sysctl.c b/kernel/sysctl.c index 6648fbb..609bed2 100644 --

Re: [PATCH v2] sched: check user input value of sysctl_sched_time_avg

2017-09-06 Thread Luis R. Rodriguez
On Mon, Sep 04, 2017 at 03:54:23PM +0800, Ethan Zhao wrote: > Peter, > > > On 2017/9/4 15:49, Peter Zijlstra wrote: > > On Sat, Sep 02, 2017 at 02:57:32PM +0800, Ethan Zhao wrote: > > > diff --git a/kernel/sysctl.c b/kernel/sysctl.c > > > index 6648fbb..609bed2 100644 > > > --- a/kernel/sysctl.c

Re: [PATCH v2] sched: check user input value of sysctl_sched_time_avg

2017-09-04 Thread Ethan Zhao
Peter, On 2017/9/4 15:49, Peter Zijlstra wrote: On Sat, Sep 02, 2017 at 02:57:32PM +0800, Ethan Zhao wrote: diff --git a/kernel/sysctl.c b/kernel/sysctl.c index 6648fbb..609bed2 100644 --- a/kernel/sysctl.c +++ b/kernel/sysctl.c @@ -367,7 +367,7 @@ static int sysrq_sysctl_handler(struct ctl_ta

Re: [PATCH v2] sched: check user input value of sysctl_sched_time_avg

2017-09-04 Thread Peter Zijlstra
On Sat, Sep 02, 2017 at 02:57:32PM +0800, Ethan Zhao wrote: > diff --git a/kernel/sysctl.c b/kernel/sysctl.c > index 6648fbb..609bed2 100644 > --- a/kernel/sysctl.c > +++ b/kernel/sysctl.c > @@ -367,7 +367,7 @@ static int sysrq_sysctl_handler(struct ctl_table *table, > int write, > .

Re: [PATCH v2] sched: check user input value of sysctl_sched_time_avg

2017-09-02 Thread Mike Galbraith
On Sat, 2017-09-02 at 14:57 +0800, Ethan Zhao wrote: > System will hang if user set sysctl_sched_time_avg to 0 by > > [root@XXX ~]# sysctl kernel.sched_time_avg_ms=0 What's wrong with using proc_dointvec_minmax? -Mike

[PATCH v2] sched: check user input value of sysctl_sched_time_avg

2017-09-02 Thread Ethan Zhao
System will hang if user set sysctl_sched_time_avg to 0 by [root@XXX ~]# sysctl kernel.sched_time_avg_ms=0 Stack traceback for pid 0 0x883f6406c600 0 0 1 3 R 0x883f6406cf50 *swapper/3 883f7ccc3ae8 0018 810c4dd0 00017800 883f7ccc3d78 000