Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On 23-05-18, 02:42, Joel Fernandes wrote: > Probably. But then Rafael is changing single policy to use the lock > so then barrier wouldn't be needed at all. In that case, both mine > and Rafael new patch can go into stable which handles your race ( > optimization == fix in this case :P ) Yeah, we

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On 23-05-18, 02:42, Joel Fernandes wrote: > Probably. But then Rafael is changing single policy to use the lock > so then barrier wouldn't be needed at all. In that case, both mine > and Rafael new patch can go into stable which handles your race ( > optimization == fix in this case :P ) Yeah, we

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On May 23, 2018 2:01:01 AM PDT, Viresh Kumar wrote: >On 22-05-18, 15:09, Joel Fernandes wrote: >> I agree with the race you describe for single policy slow-switch. >Good find :) >> >> The mainline sugov_work could also do such reordering in sugov_work, >I think. Even

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On May 23, 2018 2:01:01 AM PDT, Viresh Kumar wrote: >On 22-05-18, 15:09, Joel Fernandes wrote: >> I agree with the race you describe for single policy slow-switch. >Good find :) >> >> The mainline sugov_work could also do such reordering in sugov_work, >I think. Even >> with the mutex_unlock

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On 22-05-18, 15:09, Joel Fernandes wrote: > I agree with the race you describe for single policy slow-switch. Good find :) > > The mainline sugov_work could also do such reordering in sugov_work, I think. > Even > with the mutex_unlock in mainline's sugov_work, that work_in_progress write >

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On 22-05-18, 15:09, Joel Fernandes wrote: > I agree with the race you describe for single policy slow-switch. Good find :) > > The mainline sugov_work could also do such reordering in sugov_work, I think. > Even > with the mutex_unlock in mainline's sugov_work, that work_in_progress write >

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On Wed, May 23, 2018 at 12:09 AM, Joel Fernandes wrote: > On Tue, May 22, 2018 at 04:04:15PM +0530, Viresh Kumar wrote: >> Okay, me and Rafael were discussing this patch, locking and races around >> this. >> >> On 18-05-18, 11:55, Joel Fernandes (Google.) wrote: >> > diff

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On Wed, May 23, 2018 at 12:09 AM, Joel Fernandes wrote: > On Tue, May 22, 2018 at 04:04:15PM +0530, Viresh Kumar wrote: >> Okay, me and Rafael were discussing this patch, locking and races around >> this. >> >> On 18-05-18, 11:55, Joel Fernandes (Google.) wrote: >> > diff --git

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On Tue, May 22, 2018 at 11:52:46PM +0200, Rafael J. Wysocki wrote: > On Tue, May 22, 2018 at 11:41 PM, Joel Fernandes > wrote: > > On Tue, May 22, 2018 at 05:27:11PM +0200, Rafael J. Wysocki wrote: > >> On Tue, May 22, 2018 at 2:22 PM, Rafael J. Wysocki

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On Tue, May 22, 2018 at 11:52:46PM +0200, Rafael J. Wysocki wrote: > On Tue, May 22, 2018 at 11:41 PM, Joel Fernandes > wrote: > > On Tue, May 22, 2018 at 05:27:11PM +0200, Rafael J. Wysocki wrote: > >> On Tue, May 22, 2018 at 2:22 PM, Rafael J. Wysocki > >> wrote: > >> > On Tuesday, May 22,

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On Tue, May 22, 2018 at 04:04:15PM +0530, Viresh Kumar wrote: > Okay, me and Rafael were discussing this patch, locking and races around this. > > On 18-05-18, 11:55, Joel Fernandes (Google.) wrote: > > diff --git a/kernel/sched/cpufreq_schedutil.c > > b/kernel/sched/cpufreq_schedutil.c > >

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On Tue, May 22, 2018 at 04:04:15PM +0530, Viresh Kumar wrote: > Okay, me and Rafael were discussing this patch, locking and races around this. > > On 18-05-18, 11:55, Joel Fernandes (Google.) wrote: > > diff --git a/kernel/sched/cpufreq_schedutil.c > > b/kernel/sched/cpufreq_schedutil.c > >

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On Tue, May 22, 2018 at 11:41 PM, Joel Fernandes wrote: > On Tue, May 22, 2018 at 05:27:11PM +0200, Rafael J. Wysocki wrote: >> On Tue, May 22, 2018 at 2:22 PM, Rafael J. Wysocki >> wrote: >> > On Tuesday, May 22, 2018 1:42:05 PM CEST Rafael J.

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On Tue, May 22, 2018 at 11:41 PM, Joel Fernandes wrote: > On Tue, May 22, 2018 at 05:27:11PM +0200, Rafael J. Wysocki wrote: >> On Tue, May 22, 2018 at 2:22 PM, Rafael J. Wysocki >> wrote: >> > On Tuesday, May 22, 2018 1:42:05 PM CEST Rafael J. Wysocki wrote: >> >> On Tue, May 22, 2018 at 1:38

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On Tue, May 22, 2018 at 05:27:11PM +0200, Rafael J. Wysocki wrote: > On Tue, May 22, 2018 at 2:22 PM, Rafael J. Wysocki wrote: > > On Tuesday, May 22, 2018 1:42:05 PM CEST Rafael J. Wysocki wrote: > >> On Tue, May 22, 2018 at 1:38 PM, Viresh Kumar >

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On Tue, May 22, 2018 at 05:27:11PM +0200, Rafael J. Wysocki wrote: > On Tue, May 22, 2018 at 2:22 PM, Rafael J. Wysocki wrote: > > On Tuesday, May 22, 2018 1:42:05 PM CEST Rafael J. Wysocki wrote: > >> On Tue, May 22, 2018 at 1:38 PM, Viresh Kumar > >> wrote: > >> > On 22-05-18, 13:31, Rafael

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On Tue, May 22, 2018 at 5:30 PM, Rafael J. Wysocki wrote: > On Tue, May 22, 2018 at 12:02 PM, Rafael J. Wysocki wrote: >> On Mon, May 21, 2018 at 6:13 PM, Joel Fernandes >> wrote: >>> On Mon, May 21, 2018 at 10:29:52AM +0200, Rafael

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On Tue, May 22, 2018 at 5:30 PM, Rafael J. Wysocki wrote: > On Tue, May 22, 2018 at 12:02 PM, Rafael J. Wysocki wrote: >> On Mon, May 21, 2018 at 6:13 PM, Joel Fernandes >> wrote: >>> On Mon, May 21, 2018 at 10:29:52AM +0200, Rafael J. Wysocki wrote: On Mon, May 21, 2018 at 7:14 AM,

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On Tue, May 22, 2018 at 12:02 PM, Rafael J. Wysocki wrote: > On Mon, May 21, 2018 at 6:13 PM, Joel Fernandes > wrote: >> On Mon, May 21, 2018 at 10:29:52AM +0200, Rafael J. Wysocki wrote: >>> On Mon, May 21, 2018 at 7:14 AM, Viresh Kumar

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On Tue, May 22, 2018 at 12:02 PM, Rafael J. Wysocki wrote: > On Mon, May 21, 2018 at 6:13 PM, Joel Fernandes > wrote: >> On Mon, May 21, 2018 at 10:29:52AM +0200, Rafael J. Wysocki wrote: >>> On Mon, May 21, 2018 at 7:14 AM, Viresh Kumar >>> wrote: >>> > On 18-05-18, 11:55, Joel Fernandes

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On Tue, May 22, 2018 at 2:22 PM, Rafael J. Wysocki wrote: > On Tuesday, May 22, 2018 1:42:05 PM CEST Rafael J. Wysocki wrote: >> On Tue, May 22, 2018 at 1:38 PM, Viresh Kumar >> wrote: >> > On 22-05-18, 13:31, Rafael J. Wysocki wrote: >> >> So below

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On Tue, May 22, 2018 at 2:22 PM, Rafael J. Wysocki wrote: > On Tuesday, May 22, 2018 1:42:05 PM CEST Rafael J. Wysocki wrote: >> On Tue, May 22, 2018 at 1:38 PM, Viresh Kumar >> wrote: >> > On 22-05-18, 13:31, Rafael J. Wysocki wrote: >> >> So below is my (compiled-only) version of the $subject

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On Tuesday, May 22, 2018 1:42:05 PM CEST Rafael J. Wysocki wrote: > On Tue, May 22, 2018 at 1:38 PM, Viresh Kumar wrote: > > On 22-05-18, 13:31, Rafael J. Wysocki wrote: > >> So below is my (compiled-only) version of the $subject patch, obviously > >> based > >> on the

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On Tuesday, May 22, 2018 1:42:05 PM CEST Rafael J. Wysocki wrote: > On Tue, May 22, 2018 at 1:38 PM, Viresh Kumar wrote: > > On 22-05-18, 13:31, Rafael J. Wysocki wrote: > >> So below is my (compiled-only) version of the $subject patch, obviously > >> based > >> on the Joel's work. > >> > >>

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On Tue, May 22, 2018 at 1:38 PM, Viresh Kumar wrote: > On 22-05-18, 13:31, Rafael J. Wysocki wrote: >> So below is my (compiled-only) version of the $subject patch, obviously based >> on the Joel's work. >> >> Roughly, what it does is to move the fast_switch_enabled path

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On Tue, May 22, 2018 at 1:38 PM, Viresh Kumar wrote: > On 22-05-18, 13:31, Rafael J. Wysocki wrote: >> So below is my (compiled-only) version of the $subject patch, obviously based >> on the Joel's work. >> >> Roughly, what it does is to move the fast_switch_enabled path entirely to >>

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On 22-05-18, 13:31, Rafael J. Wysocki wrote: > So below is my (compiled-only) version of the $subject patch, obviously based > on the Joel's work. > > Roughly, what it does is to move the fast_switch_enabled path entirely to > sugov_update_single() and take the spinlock around

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On 22-05-18, 13:31, Rafael J. Wysocki wrote: > So below is my (compiled-only) version of the $subject patch, obviously based > on the Joel's work. > > Roughly, what it does is to move the fast_switch_enabled path entirely to > sugov_update_single() and take the spinlock around

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On Tuesday, May 22, 2018 12:54:29 PM CEST Viresh Kumar wrote: > On 22-05-18, 12:50, Rafael J. Wysocki wrote: > > Ugly indeed. > > Hehe. I was thinking, maybe we can write wrapper helpers around lock/unlock > which are stored as pointers in sg_policy. So that those are only set to > non-NULL

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On Tuesday, May 22, 2018 12:54:29 PM CEST Viresh Kumar wrote: > On 22-05-18, 12:50, Rafael J. Wysocki wrote: > > Ugly indeed. > > Hehe. I was thinking, maybe we can write wrapper helpers around lock/unlock > which are stored as pointers in sg_policy. So that those are only set to > non-NULL

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On Tuesday, May 22, 2018 12:02:24 PM CEST Rafael J. Wysocki wrote: > On Mon, May 21, 2018 at 6:13 PM, Joel Fernandes > wrote: > > On Mon, May 21, 2018 at 10:29:52AM +0200, Rafael J. Wysocki wrote: > >> On Mon, May 21, 2018 at 7:14 AM, Viresh Kumar

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On Tuesday, May 22, 2018 12:02:24 PM CEST Rafael J. Wysocki wrote: > On Mon, May 21, 2018 at 6:13 PM, Joel Fernandes > wrote: > > On Mon, May 21, 2018 at 10:29:52AM +0200, Rafael J. Wysocki wrote: > >> On Mon, May 21, 2018 at 7:14 AM, Viresh Kumar > >> wrote: > >> > On 18-05-18, 11:55, Joel

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On 22-05-18, 11:51, Patrick Bellasi wrote: > It could happen, but using: > >raw_spin_lock_irqsave(_policy->update_lock, flags); >freq = READ_ONCE(sg_policy->next_freq) >WRITE_ONCE(sg_policy->work_in_progress, false); >raw_spin_unlock_irqrestore(_policy->update_lock, flags); > >

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On 22-05-18, 11:51, Patrick Bellasi wrote: > It could happen, but using: > >raw_spin_lock_irqsave(_policy->update_lock, flags); >freq = READ_ONCE(sg_policy->next_freq) >WRITE_ONCE(sg_policy->work_in_progress, false); >raw_spin_unlock_irqrestore(_policy->update_lock, flags); > >

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On 22-05-18, 12:50, Rafael J. Wysocki wrote: > Ugly indeed. Hehe. I was thinking, maybe we can write wrapper helpers around lock/unlock which are stored as pointers in sg_policy. So that those are only set to non-NULL values (or non-Noop routines) for slow-switching single policy or any-switching

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On 22-05-18, 12:50, Rafael J. Wysocki wrote: > Ugly indeed. Hehe. I was thinking, maybe we can write wrapper helpers around lock/unlock which are stored as pointers in sg_policy. So that those are only set to non-NULL values (or non-Noop routines) for slow-switching single policy or any-switching

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On 22-May 16:04, Viresh Kumar wrote: > Okay, me and Rafael were discussing this patch, locking and races around this. > > On 18-05-18, 11:55, Joel Fernandes (Google.) wrote: > > @@ -382,13 +386,27 @@ sugov_update_shared(struct update_util_data *hook, > > u64 time, unsigned int flags) > > static

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On 22-May 16:04, Viresh Kumar wrote: > Okay, me and Rafael were discussing this patch, locking and races around this. > > On 18-05-18, 11:55, Joel Fernandes (Google.) wrote: > > @@ -382,13 +386,27 @@ sugov_update_shared(struct update_util_data *hook, > > u64 time, unsigned int flags) > > static

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On Tuesday, May 22, 2018 12:50:06 PM CEST Viresh Kumar wrote: > On 22-05-18, 16:04, Viresh Kumar wrote: > > Okay, me and Rafael were discussing this patch, locking and races around > > this. > > > > On 18-05-18, 11:55, Joel Fernandes (Google.) wrote: > > > diff --git

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On Tuesday, May 22, 2018 12:50:06 PM CEST Viresh Kumar wrote: > On 22-05-18, 16:04, Viresh Kumar wrote: > > Okay, me and Rafael were discussing this patch, locking and races around > > this. > > > > On 18-05-18, 11:55, Joel Fernandes (Google.) wrote: > > > diff --git

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On 22-05-18, 16:04, Viresh Kumar wrote: > Okay, me and Rafael were discussing this patch, locking and races around this. > > On 18-05-18, 11:55, Joel Fernandes (Google.) wrote: > > diff --git a/kernel/sched/cpufreq_schedutil.c > > b/kernel/sched/cpufreq_schedutil.c > > index

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On 22-05-18, 16:04, Viresh Kumar wrote: > Okay, me and Rafael were discussing this patch, locking and races around this. > > On 18-05-18, 11:55, Joel Fernandes (Google.) wrote: > > diff --git a/kernel/sched/cpufreq_schedutil.c > > b/kernel/sched/cpufreq_schedutil.c > > index

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

Hi Viresh, thanks for clarifying... On 22-May 15:53, Viresh Kumar wrote: > On 21-05-18, 10:20, Joel Fernandes wrote: > > On Mon, May 21, 2018 at 06:00:50PM +0100, Patrick Bellasi wrote: > > > If that's the case, this means that if, for example, during a > > > frequency switch you get a request to

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

Hi Viresh, thanks for clarifying... On 22-May 15:53, Viresh Kumar wrote: > On 21-05-18, 10:20, Joel Fernandes wrote: > > On Mon, May 21, 2018 at 06:00:50PM +0100, Patrick Bellasi wrote: > > > If that's the case, this means that if, for example, during a > > > frequency switch you get a request to

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

Okay, me and Rafael were discussing this patch, locking and races around this. On 18-05-18, 11:55, Joel Fernandes (Google.) wrote: > diff --git a/kernel/sched/cpufreq_schedutil.c > b/kernel/sched/cpufreq_schedutil.c > index e13df951aca7..5c482ec38610 100644 > ---

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

Okay, me and Rafael were discussing this patch, locking and races around this. On 18-05-18, 11:55, Joel Fernandes (Google.) wrote: > diff --git a/kernel/sched/cpufreq_schedutil.c > b/kernel/sched/cpufreq_schedutil.c > index e13df951aca7..5c482ec38610 100644 > ---

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On 21-May 11:05, Joel Fernandes wrote: > On Mon, May 21, 2018 at 11:50:55AM +0100, Patrick Bellasi wrote: > > On 18-May 11:55, Joel Fernandes (Google.) wrote: > > > From: "Joel Fernandes (Google)" > > > > > > Currently there is a chance of a schedutil cpufreq update

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On 21-May 11:05, Joel Fernandes wrote: > On Mon, May 21, 2018 at 11:50:55AM +0100, Patrick Bellasi wrote: > > On 18-May 11:55, Joel Fernandes (Google.) wrote: > > > From: "Joel Fernandes (Google)" > > > > > > Currently there is a chance of a schedutil cpufreq update request to be > > > dropped

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On 21-05-18, 10:20, Joel Fernandes wrote: > On Mon, May 21, 2018 at 06:00:50PM +0100, Patrick Bellasi wrote: > > If that's the case, this means that if, for example, during a > > frequency switch you get a request to reduce the frequency (e.g. > > deadline task passing the 0-lag time) and right

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On 21-05-18, 10:20, Joel Fernandes wrote: > On Mon, May 21, 2018 at 06:00:50PM +0100, Patrick Bellasi wrote: > > If that's the case, this means that if, for example, during a > > frequency switch you get a request to reduce the frequency (e.g. > > deadline task passing the 0-lag time) and right

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On Mon, May 21, 2018 at 6:13 PM, Joel Fernandes wrote: > On Mon, May 21, 2018 at 10:29:52AM +0200, Rafael J. Wysocki wrote: >> On Mon, May 21, 2018 at 7:14 AM, Viresh Kumar >> wrote: >> > On 18-05-18, 11:55, Joel Fernandes (Google.) wrote: >> >>

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On Mon, May 21, 2018 at 6:13 PM, Joel Fernandes wrote: > On Mon, May 21, 2018 at 10:29:52AM +0200, Rafael J. Wysocki wrote: >> On Mon, May 21, 2018 at 7:14 AM, Viresh Kumar >> wrote: >> > On 18-05-18, 11:55, Joel Fernandes (Google.) wrote: >> >> From: "Joel Fernandes (Google)" >> >> >> >>

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On Mon, May 21, 2018 at 11:50:55AM +0100, Patrick Bellasi wrote: > On 18-May 11:55, Joel Fernandes (Google.) wrote: > > From: "Joel Fernandes (Google)" > > > > Currently there is a chance of a schedutil cpufreq update request to be > > dropped if there is a pending update

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On Mon, May 21, 2018 at 11:50:55AM +0100, Patrick Bellasi wrote: > On 18-May 11:55, Joel Fernandes (Google.) wrote: > > From: "Joel Fernandes (Google)" > > > > Currently there is a chance of a schedutil cpufreq update request to be > > dropped if there is a pending update request. This pending

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On 21-May 10:20, Joel Fernandes wrote: > Hi Patrick, > > On Mon, May 21, 2018 at 06:00:50PM +0100, Patrick Bellasi wrote: > > On 21-May 08:49, Joel Fernandes wrote: > > > On Mon, May 21, 2018 at 11:50:55AM +0100, Patrick Bellasi wrote: > > > > On 18-May 11:55, Joel Fernandes (Google.) wrote: > >

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On 21-May 10:20, Joel Fernandes wrote: > Hi Patrick, > > On Mon, May 21, 2018 at 06:00:50PM +0100, Patrick Bellasi wrote: > > On 21-May 08:49, Joel Fernandes wrote: > > > On Mon, May 21, 2018 at 11:50:55AM +0100, Patrick Bellasi wrote: > > > > On 18-May 11:55, Joel Fernandes (Google.) wrote: > >

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

Hi Patrick, On Mon, May 21, 2018 at 06:00:50PM +0100, Patrick Bellasi wrote: > On 21-May 08:49, Joel Fernandes wrote: > > On Mon, May 21, 2018 at 11:50:55AM +0100, Patrick Bellasi wrote: > > > On 18-May 11:55, Joel Fernandes (Google.) wrote: > > > > From: "Joel Fernandes (Google)"

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

Hi Patrick, On Mon, May 21, 2018 at 06:00:50PM +0100, Patrick Bellasi wrote: > On 21-May 08:49, Joel Fernandes wrote: > > On Mon, May 21, 2018 at 11:50:55AM +0100, Patrick Bellasi wrote: > > > On 18-May 11:55, Joel Fernandes (Google.) wrote: > > > > From: "Joel Fernandes (Google)" > > > > > > >

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On 21-May 08:49, Joel Fernandes wrote: > On Mon, May 21, 2018 at 11:50:55AM +0100, Patrick Bellasi wrote: > > On 18-May 11:55, Joel Fernandes (Google.) wrote: > > > From: "Joel Fernandes (Google)" > > > > > > Currently there is a chance of a schedutil cpufreq update

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On 21-May 08:49, Joel Fernandes wrote: > On Mon, May 21, 2018 at 11:50:55AM +0100, Patrick Bellasi wrote: > > On 18-May 11:55, Joel Fernandes (Google.) wrote: > > > From: "Joel Fernandes (Google)" > > > > > > Currently there is a chance of a schedutil cpufreq update request to be > > > dropped

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On Mon, May 21, 2018 at 10:29:52AM +0200, Rafael J. Wysocki wrote: > On Mon, May 21, 2018 at 7:14 AM, Viresh Kumar wrote: > > On 18-05-18, 11:55, Joel Fernandes (Google.) wrote: > >> From: "Joel Fernandes (Google)" > >> > >> Currently there is a

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On Mon, May 21, 2018 at 10:29:52AM +0200, Rafael J. Wysocki wrote: > On Mon, May 21, 2018 at 7:14 AM, Viresh Kumar wrote: > > On 18-05-18, 11:55, Joel Fernandes (Google.) wrote: > >> From: "Joel Fernandes (Google)" > >> > >> Currently there is a chance of a schedutil cpufreq update request to be

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On Mon, May 21, 2018 at 11:50:55AM +0100, Patrick Bellasi wrote: > On 18-May 11:55, Joel Fernandes (Google.) wrote: > > From: "Joel Fernandes (Google)" > > > > Currently there is a chance of a schedutil cpufreq update request to be > > dropped if there is a pending update

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On Mon, May 21, 2018 at 11:50:55AM +0100, Patrick Bellasi wrote: > On 18-May 11:55, Joel Fernandes (Google.) wrote: > > From: "Joel Fernandes (Google)" > > > > Currently there is a chance of a schedutil cpufreq update request to be > > dropped if there is a pending update request. This pending

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On 18-May 11:55, Joel Fernandes (Google.) wrote: > From: "Joel Fernandes (Google)" > > Currently there is a chance of a schedutil cpufreq update request to be > dropped if there is a pending update request. This pending request can > be delayed if there is a scheduling

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On 18-May 11:55, Joel Fernandes (Google.) wrote: > From: "Joel Fernandes (Google)" > > Currently there is a chance of a schedutil cpufreq update request to be > dropped if there is a pending update request. This pending request can > be delayed if there is a scheduling delay of the irq_work and

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On 21/05/18 10:29, Rafael J. Wysocki wrote: > On Mon, May 21, 2018 at 7:14 AM, Viresh Kumar wrote: > > On 18-05-18, 11:55, Joel Fernandes (Google.) wrote: > >> From: "Joel Fernandes (Google)" > >> > >> Currently there is a chance of a schedutil

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On 21/05/18 10:29, Rafael J. Wysocki wrote: > On Mon, May 21, 2018 at 7:14 AM, Viresh Kumar wrote: > > On 18-05-18, 11:55, Joel Fernandes (Google.) wrote: > >> From: "Joel Fernandes (Google)" > >> > >> Currently there is a chance of a schedutil cpufreq update request to be > >> dropped if there

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On Mon, May 21, 2018 at 7:14 AM, Viresh Kumar wrote: > On 18-05-18, 11:55, Joel Fernandes (Google.) wrote: >> From: "Joel Fernandes (Google)" >> >> Currently there is a chance of a schedutil cpufreq update request to be >> dropped if there is a

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On Mon, May 21, 2018 at 7:14 AM, Viresh Kumar wrote: > On 18-05-18, 11:55, Joel Fernandes (Google.) wrote: >> From: "Joel Fernandes (Google)" >> >> Currently there is a chance of a schedutil cpufreq update request to be >> dropped if there is a pending update request. This pending request can >>

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On 18-05-18, 11:55, Joel Fernandes (Google.) wrote: > From: "Joel Fernandes (Google)" > > Currently there is a chance of a schedutil cpufreq update request to be > dropped if there is a pending update request. This pending request can > be delayed if there is a scheduling

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On 18-05-18, 11:55, Joel Fernandes (Google.) wrote: > From: "Joel Fernandes (Google)" > > Currently there is a chance of a schedutil cpufreq update request to be > dropped if there is a pending update request. This pending request can > be delayed if there is a scheduling delay of the irq_work

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On Fri, May 18, 2018 at 11:13 PM, Saravana Kannan wrote: > On 05/18/2018 11:55 AM, Joel Fernandes (Google.) wrote: >> >> From: "Joel Fernandes (Google)" >> >> Currently there is a chance of a schedutil cpufreq update request to be >> dropped if

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On Fri, May 18, 2018 at 11:13 PM, Saravana Kannan wrote: > On 05/18/2018 11:55 AM, Joel Fernandes (Google.) wrote: >> >> From: "Joel Fernandes (Google)" >> >> Currently there is a chance of a schedutil cpufreq update request to be >> dropped if there is a pending update request. This pending

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On 05/18/2018 11:55 AM, Joel Fernandes (Google.) wrote: From: "Joel Fernandes (Google)" Currently there is a chance of a schedutil cpufreq update request to be dropped if there is a pending update request. This pending request can be delayed if there is a scheduling

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On 05/18/2018 11:55 AM, Joel Fernandes (Google.) wrote: From: "Joel Fernandes (Google)" Currently there is a chance of a schedutil cpufreq update request to be dropped if there is a pending update request. This pending request can be delayed if there is a scheduling delay of the irq_work and

[PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

From: "Joel Fernandes (Google)" Currently there is a chance of a schedutil cpufreq update request to be dropped if there is a pending update request. This pending request can be delayed if there is a scheduling delay of the irq_work and the wake up of the schedutil

[PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

From: "Joel Fernandes (Google)" Currently there is a chance of a schedutil cpufreq update request to be dropped if there is a pending update request. This pending request can be delayed if there is a scheduling delay of the irq_work and the wake up of the schedutil governor kthread. A very bad