Re: [PATCH v2] scripts/setlocalversion: Improve -dirty check with git-status --no-optional-locks

2018-11-14 Thread Brian Norris
On Tue, Nov 13, 2018 at 2:03 PM Andreas Schwab wrote: > > On Nov 13 2018, Brian Norris wrote: > > > + } | grep -qv '^\(.. \)\?scripts/package'; then > > \? is a GNU extension, so if you want to stay portable you need to > switch to ERE. Ack. That's what I get for reading the GNU man

Re: [PATCH v2] scripts/setlocalversion: Improve -dirty check with git-status --no-optional-locks

2018-11-13 Thread Andreas Schwab
On Nov 13 2018, Brian Norris wrote: > + } | grep -qv '^\(.. \)\?scripts/package'; then \? is a GNU extension, so if you want to stay portable you need to switch to ERE. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780

Re: [PATCH v2] scripts/setlocalversion: Improve -dirty check with git-status --no-optional-locks

2018-11-13 Thread Genki Sky
Thanks all, On Tue, 13 Nov 2018 11:03:36 -0800, Brian Norris wrote: > [ ... ] > > Cc: Genki Sky > Cc: Christian Kujau > Cc: Guenter Roeck > Suggested-by: Alexander Kapshuk > Signed-off-by: Brian Norris Tested-by: Genki Sky

[PATCH v2] scripts/setlocalversion: Improve -dirty check with git-status --no-optional-locks

2018-11-13 Thread Brian Norris
git-diff-index does not refresh the index for you, so using it for a "-dirty" check can give misleading results. Commit 6147b1cf19651 ("scripts/setlocalversion: git: Make -dirty check more robust") tried to fix this by switching to git-status, but it overlooked the fact that git-status also writes