On Thu, 2014-06-26 at 14:12 +0200, Maurizio Lombardi wrote:
>
> On 06/26/2014 02:05 PM, Joe Perches wrote:
> > On Thu, 2014-06-26 at 13:54 +0200, Rickard Strandqvist wrote:
> >> A struct member variable is set to different values without having used in
> >> between.
> > []
> >> diff --git
On 06/26/2014 01:54 PM, Rickard Strandqvist wrote:
> A struct member variable is set to different values without having used in
> between.
It is almost ok for me but I think you should mention that it also fixes a bug,
or the commit message will be misleading.
>
> This was found using a
On 06/26/2014 02:05 PM, Joe Perches wrote:
> On Thu, 2014-06-26 at 13:54 +0200, Rickard Strandqvist wrote:
>> A struct member variable is set to different values without having used in
>> between.
> []
>> diff --git a/drivers/scsi/bnx2i/bnx2i_iscsi.c
>> b/drivers/scsi/bnx2i/bnx2i_iscsi.c
> []
On Thu, 2014-06-26 at 13:54 +0200, Rickard Strandqvist wrote:
> A struct member variable is set to different values without having used in
> between.
[]
> diff --git a/drivers/scsi/bnx2i/bnx2i_iscsi.c
> b/drivers/scsi/bnx2i/bnx2i_iscsi.c
[]
> @@ -1643,12 +1643,11 @@ static void
A struct member variable is set to different values without having used in
between.
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist
---
drivers/scsi/bnx2i/bnx2i_iscsi.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff
A struct member variable is set to different values without having used in
between.
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se
---
drivers/scsi/bnx2i/bnx2i_iscsi.c |3 +--
1 file changed, 1
On Thu, 2014-06-26 at 13:54 +0200, Rickard Strandqvist wrote:
A struct member variable is set to different values without having used in
between.
[]
diff --git a/drivers/scsi/bnx2i/bnx2i_iscsi.c
b/drivers/scsi/bnx2i/bnx2i_iscsi.c
[]
@@ -1643,12 +1643,11 @@ static void
On 06/26/2014 02:05 PM, Joe Perches wrote:
On Thu, 2014-06-26 at 13:54 +0200, Rickard Strandqvist wrote:
A struct member variable is set to different values without having used in
between.
[]
diff --git a/drivers/scsi/bnx2i/bnx2i_iscsi.c
b/drivers/scsi/bnx2i/bnx2i_iscsi.c
[]
@@
On 06/26/2014 01:54 PM, Rickard Strandqvist wrote:
A struct member variable is set to different values without having used in
between.
It is almost ok for me but I think you should mention that it also fixes a bug,
or the commit message will be misleading.
This was found using a static
On Thu, 2014-06-26 at 14:12 +0200, Maurizio Lombardi wrote:
On 06/26/2014 02:05 PM, Joe Perches wrote:
On Thu, 2014-06-26 at 13:54 +0200, Rickard Strandqvist wrote:
A struct member variable is set to different values without having used in
between.
[]
diff --git
10 matches
Mail list logo