Re: [PATCH v2] scsi: bnx2i: bnx2i_iscsi.c: Cleaning up variable is set more than once

2014-06-26 Thread Joe Perches
On Thu, 2014-06-26 at 14:12 +0200, Maurizio Lombardi wrote: > > On 06/26/2014 02:05 PM, Joe Perches wrote: > > On Thu, 2014-06-26 at 13:54 +0200, Rickard Strandqvist wrote: > >> A struct member variable is set to different values without having used in > >> between. > > [] > >> diff --git

Re: [PATCH v2] scsi: bnx2i: bnx2i_iscsi.c: Cleaning up variable is set more than once

2014-06-26 Thread Maurizio Lombardi
On 06/26/2014 01:54 PM, Rickard Strandqvist wrote: > A struct member variable is set to different values without having used in > between. It is almost ok for me but I think you should mention that it also fixes a bug, or the commit message will be misleading. > > This was found using a

Re: [PATCH v2] scsi: bnx2i: bnx2i_iscsi.c: Cleaning up variable is set more than once

2014-06-26 Thread Maurizio Lombardi
On 06/26/2014 02:05 PM, Joe Perches wrote: > On Thu, 2014-06-26 at 13:54 +0200, Rickard Strandqvist wrote: >> A struct member variable is set to different values without having used in >> between. > [] >> diff --git a/drivers/scsi/bnx2i/bnx2i_iscsi.c >> b/drivers/scsi/bnx2i/bnx2i_iscsi.c > []

Re: [PATCH v2] scsi: bnx2i: bnx2i_iscsi.c: Cleaning up variable is set more than once

2014-06-26 Thread Joe Perches
On Thu, 2014-06-26 at 13:54 +0200, Rickard Strandqvist wrote: > A struct member variable is set to different values without having used in > between. [] > diff --git a/drivers/scsi/bnx2i/bnx2i_iscsi.c > b/drivers/scsi/bnx2i/bnx2i_iscsi.c [] > @@ -1643,12 +1643,11 @@ static void

[PATCH v2] scsi: bnx2i: bnx2i_iscsi.c: Cleaning up variable is set more than once

2014-06-26 Thread Rickard Strandqvist
A struct member variable is set to different values without having used in between. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/scsi/bnx2i/bnx2i_iscsi.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff

[PATCH v2] scsi: bnx2i: bnx2i_iscsi.c: Cleaning up variable is set more than once

2014-06-26 Thread Rickard Strandqvist
A struct member variable is set to different values without having used in between. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se --- drivers/scsi/bnx2i/bnx2i_iscsi.c |3 +-- 1 file changed, 1

Re: [PATCH v2] scsi: bnx2i: bnx2i_iscsi.c: Cleaning up variable is set more than once

2014-06-26 Thread Joe Perches
On Thu, 2014-06-26 at 13:54 +0200, Rickard Strandqvist wrote: A struct member variable is set to different values without having used in between. [] diff --git a/drivers/scsi/bnx2i/bnx2i_iscsi.c b/drivers/scsi/bnx2i/bnx2i_iscsi.c [] @@ -1643,12 +1643,11 @@ static void

Re: [PATCH v2] scsi: bnx2i: bnx2i_iscsi.c: Cleaning up variable is set more than once

2014-06-26 Thread Maurizio Lombardi
On 06/26/2014 02:05 PM, Joe Perches wrote: On Thu, 2014-06-26 at 13:54 +0200, Rickard Strandqvist wrote: A struct member variable is set to different values without having used in between. [] diff --git a/drivers/scsi/bnx2i/bnx2i_iscsi.c b/drivers/scsi/bnx2i/bnx2i_iscsi.c [] @@

Re: [PATCH v2] scsi: bnx2i: bnx2i_iscsi.c: Cleaning up variable is set more than once

2014-06-26 Thread Maurizio Lombardi
On 06/26/2014 01:54 PM, Rickard Strandqvist wrote: A struct member variable is set to different values without having used in between. It is almost ok for me but I think you should mention that it also fixes a bug, or the commit message will be misleading. This was found using a static

Re: [PATCH v2] scsi: bnx2i: bnx2i_iscsi.c: Cleaning up variable is set more than once

2014-06-26 Thread Joe Perches
On Thu, 2014-06-26 at 14:12 +0200, Maurizio Lombardi wrote: On 06/26/2014 02:05 PM, Joe Perches wrote: On Thu, 2014-06-26 at 13:54 +0200, Rickard Strandqvist wrote: A struct member variable is set to different values without having used in between. [] diff --git