Re: [PATCH v2] scsi: qla4xxx: Don't call dma_free_coherent when buf is NULL

2019-03-08 Thread Nick Desaulniers
On Thu, Mar 7, 2019 at 3:17 PM Nathan Chancellor wrote: > > When building with -Wsometimes-uninitialized, Clang warns: > > drivers/scsi/qla4xxx/ql4_os.c:5915:7: warning: variable 'buf_dma' is > used uninitialized whenever 'if' condition is false > [-Wsometimes-uninitialized] > > Don't call

[PATCH v2] scsi: qla4xxx: Don't call dma_free_coherent when buf is NULL

2019-03-07 Thread Nathan Chancellor
When building with -Wsometimes-uninitialized, Clang warns: drivers/scsi/qla4xxx/ql4_os.c:5915:7: warning: variable 'buf_dma' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] Don't call dma_free_coherent when buf is NULL, meaning that we never called