Re: [PATCH v2] scsi: st: convert convert get_user_pages() --> pin_user_pages()

2020-06-09 Thread Martin K. Petersen
On Tue, 26 May 2020 11:27:09 -0700, John Hubbard wrote: > This code was using get_user_pages*(), in a "Case 1" scenario > (Direct IO), using the categorization from [1]. That means that it's > time to convert the get_user_pages*() + put_page() calls to > pin_user_pages*() + unpin_user_pages()

Re: [PATCH v2] scsi: st: convert convert get_user_pages() --> pin_user_pages()

2020-06-05 Thread Kai Mäkisara (Kolumbus)
> On 26. May 2020, at 21.27, John Hubbard wrote: > > This code was using get_user_pages*(), in a "Case 1" scenario > (Direct IO), using the categorization from [1]. That means that it's > time to convert the get_user_pages*() + put_page() calls to > pin_user_pages*() + unpin_user_pages()

Re: [PATCH v2] scsi: st: convert convert get_user_pages() --> pin_user_pages()

2020-06-02 Thread Martin K. Petersen
> This code was using get_user_pages*(), in a "Case 1" scenario (Direct > IO), using the categorization from [1]. That means that it's time to > convert the get_user_pages*() + put_page() calls to pin_user_pages*() > + unpin_user_pages() calls. Kai: Please review. Thanks! -- Martin K.

Re: [PATCH v2] scsi: st: convert convert get_user_pages() --> pin_user_pages()

2020-05-26 Thread Martin K. Petersen
John, > For some reason, the "convert convert" subject line is really hard to > get rid of from my scsi st patch. In this case, I'd dropped the patch > entirely, and recreated it with the old subject line somehow. Sorry > about that persistent typo! > > I'll send a v3 if necessary, to correct

Re: [PATCH v2] scsi: st: convert convert get_user_pages() --> pin_user_pages()

2020-05-26 Thread John Hubbard
For some reason, the "convert convert" subject line is really hard to get rid of from my scsi st patch. In this case, I'd dropped the patch entirely, and recreated it with the old subject line somehow. Sorry about that persistent typo! I'll send a v3 if necessary, to correct that. thanks, John

[PATCH v2] scsi: st: convert convert get_user_pages() --> pin_user_pages()

2020-05-26 Thread John Hubbard
This code was using get_user_pages*(), in a "Case 1" scenario (Direct IO), using the categorization from [1]. That means that it's time to convert the get_user_pages*() + put_page() calls to pin_user_pages*() + unpin_user_pages() calls. There is some helpful background in [2]: basically, this is