Re: [PATCH v2] selftests/livepatch: introduce tests

2018-04-10 Thread kbuild test robot
Hi Joe, Thank you for the patch! Yet something to improve: [auto build test ERROR on v4.16] [also build test ERROR on next-20180410] [cannot apply to linus/master jikos-livepatching/for-next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v2] selftests/livepatch: introduce tests

2018-04-10 Thread Jiri Kosina
On Tue, 10 Apr 2018, Josh Poimboeuf wrote: > I think CONFIG_LOCKDEP is always a good idea. FWIW CONFIG_LOCKDEP mostly enables the infrastructure, but CONFIG_PROVE_LOCKING is what turns most of the cleverness on. -- Jiri Kosina SUSE Labs

Re: [PATCH v2] selftests/livepatch: introduce tests

2018-04-10 Thread Josh Poimboeuf
On Tue, Apr 10, 2018 at 04:50:51PM -0400, Joe Lawrence wrote: > On 04/10/2018 04:00 PM, Josh Poimboeuf wrote: > > On Tue, Apr 10, 2018 at 11:15:54AM -0400, Joe Lawrence wrote: > >> +static void test_klp_shadow_vars_exit(void) > >> +{ > >> +} > >> + > >> +module_init(test_klp_shadow_vars_init); > >>

Re: [PATCH v2] selftests/livepatch: introduce tests

2018-04-10 Thread Joe Lawrence
On 04/10/2018 04:00 PM, Josh Poimboeuf wrote: > On Tue, Apr 10, 2018 at 11:15:54AM -0400, Joe Lawrence wrote: >> +static void test_klp_shadow_vars_exit(void) >> +{ >> +} >> + >> +module_init(test_klp_shadow_vars_init); >> +module_init(test_klp_shadow_vars_exit); > > For this last line, s/module_in

Re: [PATCH v2] selftests/livepatch: introduce tests

2018-04-10 Thread Josh Poimboeuf
On Tue, Apr 10, 2018 at 11:15:54AM -0400, Joe Lawrence wrote: > +static void test_klp_shadow_vars_exit(void) > +{ > +} > + > +module_init(test_klp_shadow_vars_init); > +module_init(test_klp_shadow_vars_exit); For this last line, s/module_init/module_exit/, though I think the exit function can just

[PATCH v2] selftests/livepatch: introduce tests

2018-04-10 Thread Joe Lawrence
Add a few livepatch modules and simple target modules that the included regression suite can run tests against. Signed-off-by: Joe Lawrence --- Documentation/livepatch/callbacks.txt | 487 - lib/Kconfig.debug | 12 + lib/Makefile