Re: [PATCH v2] selftests: kvm: Adding config fragments

2019-08-09 Thread Naresh Kamboju
On Thu, 8 Aug 2019 at 21:30, Paolo Bonzini wrote: > > On 08/08/19 17:10, Andrew Jones wrote: > >> > > What does the kselftests config file do? I was about to complain that this > > would break compiling on non-x86 platforms, but 'make kselftest' and other > > forms of invoking the build work fine

Re: [PATCH v2] selftests: kvm: Adding config fragments

2019-08-09 Thread Naresh Kamboju
On Thu, 8 Aug 2019 at 20:40, Andrew Jones wrote: > > On Thu, Aug 08, 2019 at 01:31:40PM +0100, Naresh Kamboju wrote: > > selftests kvm all test cases need pre-required kernel configs for the > > tests to get pass. > > > > The KVM tests are skipped without these configs: > > > > dev_fd =

Re: [PATCH v2] selftests: kvm: Adding config fragments

2019-08-08 Thread shuah
On 8/8/19 6:31 AM, Naresh Kamboju wrote: selftests kvm all test cases need pre-required kernel configs for the tests to get pass. The KVM tests are skipped without these configs: dev_fd = open(KVM_DEV_PATH, O_RDONLY); if (dev_fd < 0) exit(KSFT_SKIP);

Re: [PATCH v2] selftests: kvm: Adding config fragments

2019-08-08 Thread Paolo Bonzini
On 08/08/19 17:10, Andrew Jones wrote: >> > What does the kselftests config file do? I was about to complain that this > would break compiling on non-x86 platforms, but 'make kselftest' and other > forms of invoking the build work fine on aarch64 even with this config > file. So is this just for

Re: [PATCH v2] selftests: kvm: Adding config fragments

2019-08-08 Thread Andrew Jones
On Thu, Aug 08, 2019 at 01:31:40PM +0100, Naresh Kamboju wrote: > selftests kvm all test cases need pre-required kernel configs for the > tests to get pass. > > The KVM tests are skipped without these configs: > > dev_fd = open(KVM_DEV_PATH, O_RDONLY); > if (dev_fd < 0) >

[PATCH v2] selftests: kvm: Adding config fragments

2019-08-08 Thread Naresh Kamboju
selftests kvm all test cases need pre-required kernel configs for the tests to get pass. The KVM tests are skipped without these configs: dev_fd = open(KVM_DEV_PATH, O_RDONLY); if (dev_fd < 0) exit(KSFT_SKIP); Signed-off-by: Naresh Kamboju ---

Re: [PATCH v2] selftests: kvm: Adding config fragments

2019-08-07 Thread shuah
On 8/7/19 10:19 AM, Paolo Bonzini wrote: On 07/08/19 17:52, shuah wrote: On 8/7/19 7:58 AM, Naresh Kamboju wrote: selftests kvm test cases need pre-required kernel configs for the test to get pass. Can you elaborate and add more information on which tests fail without these configs. I am

Re: [PATCH v2] selftests: kvm: Adding config fragments

2019-08-07 Thread Paolo Bonzini
On 07/08/19 17:52, shuah wrote: > > > On 8/7/19 7:58 AM, Naresh Kamboju wrote: >> selftests kvm test cases need pre-required kernel configs for the test >> to get pass. >> > > Can you elaborate and add more information on which tests fail without > these configs. I am all for adding configs,

Re: [PATCH v2] selftests: kvm: Adding config fragments

2019-08-07 Thread shuah
Hi Naresh, On 8/7/19 7:58 AM, Naresh Kamboju wrote: selftests kvm test cases need pre-required kernel configs for the test to get pass. Can you elaborate and add more information on which tests fail without these configs. I am all for adding configs, however I would like to see more

[PATCH v2] selftests: kvm: Adding config fragments

2019-08-07 Thread Naresh Kamboju
selftests kvm test cases need pre-required kernel configs for the test to get pass. Signed-off-by: Naresh Kamboju --- tools/testing/selftests/kvm/config | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 tools/testing/selftests/kvm/config diff --git