Re: [PATCH v2] selftests: watchdog: Validate optional file argument

2019-09-17 Thread Eugeniu Rosca
(For LKML readability) Superseded by: - https://patchwork.kernel.org/patch/11149287/ ("[v3,1/2] selftests: watchdog: Validate optional file argument") - https://patchwork.kernel.org/patch/11149289/ ("[v3,2/2] selftests: watchdog: Add command line option to show watchdog_info") -- Best Re

Re: [PATCH v2] selftests: watchdog: Validate optional file argument

2019-09-17 Thread George G. Davis
On Tue, Sep 17, 2019 at 02:32:47PM -0400, George G. Davis wrote: > Hello Shuah, > > On Tue, Sep 17, 2019 at 12:05:06PM -0600, shuah wrote: > > On 9/17/19 11:50 AM, Eugeniu Rosca wrote: > > >On Tue, Sep 17, 2019 at 11:44:45AM -0600, shuah wrote: > > >>On 9/17/19 10:54 AM, Eugeniu Rosca wrote: > > >

Re: [PATCH v2] selftests: watchdog: Validate optional file argument

2019-09-17 Thread George G. Davis
Hello Shuah, On Tue, Sep 17, 2019 at 12:05:06PM -0600, shuah wrote: > On 9/17/19 11:50 AM, Eugeniu Rosca wrote: > >On Tue, Sep 17, 2019 at 11:44:45AM -0600, shuah wrote: > >>On 9/17/19 10:54 AM, Eugeniu Rosca wrote: > >>>Shuah, > >>> > >>>On Tue, Sep 17, 2019 at 09:25:31AM -0600, shuah wrote: > >>

Re: [PATCH v2] selftests: watchdog: Validate optional file argument

2019-09-17 Thread shuah
On 9/17/19 11:50 AM, Eugeniu Rosca wrote: On Tue, Sep 17, 2019 at 11:44:45AM -0600, shuah wrote: On 9/17/19 10:54 AM, Eugeniu Rosca wrote: Shuah, On Tue, Sep 17, 2019 at 09:25:31AM -0600, shuah wrote: [..] I want two patches and the first one with Fixes tag. These two patches need to be

Re: [PATCH v2] selftests: watchdog: Validate optional file argument

2019-09-17 Thread Eugeniu Rosca
On Tue, Sep 17, 2019 at 11:44:45AM -0600, shuah wrote: > On 9/17/19 10:54 AM, Eugeniu Rosca wrote: > > Shuah, > > > > On Tue, Sep 17, 2019 at 09:25:31AM -0600, shuah wrote: > > > > [..] > > > > > I want two patches and the first one with > > > Fixes tag. > > > > These two patches need to be se

Re: [PATCH v2] selftests: watchdog: Validate optional file argument

2019-09-17 Thread shuah
On 9/17/19 10:54 AM, Eugeniu Rosca wrote: Shuah, On Tue, Sep 17, 2019 at 09:25:31AM -0600, shuah wrote: [..] I want two patches and the first one with Fixes tag. These two patches need to be separate. The first one is a fix and the second is an enhancement. Please send two patches - the

Re: [PATCH v2] selftests: watchdog: Validate optional file argument

2019-09-17 Thread Eugeniu Rosca
Shuah, On Tue, Sep 17, 2019 at 09:25:31AM -0600, shuah wrote: [..] > I want two patches and the first one with > Fixes tag. I am not sure we are on the same page and you don't seem to be receptive to what I say. > The reason for that is that the first patch fixes a problem > in patch that is

Re: [PATCH v2] selftests: watchdog: Validate optional file argument

2019-09-17 Thread shuah
On 9/17/19 8:54 AM, Eugeniu Rosca wrote: Shuah, On Mon, Sep 16, 2019 at 07:19:35PM -0600, shuah wrote: On 9/16/19 12:49 PM, George G. Davis wrote: As reported by Eugeniu Rosca, a side of affect of commit c3f2490d6e92 ("selftests: watchdog: Add optional file argument") is that arbitrary files m

Re: [PATCH v2] selftests: watchdog: Validate optional file argument

2019-09-17 Thread Eugeniu Rosca
Shuah, On Mon, Sep 16, 2019 at 07:19:35PM -0600, shuah wrote: > On 9/16/19 12:49 PM, George G. Davis wrote: > > As reported by Eugeniu Rosca, a side of affect of commit c3f2490d6e92 > > ("selftests: watchdog: Add optional file argument") is that arbitrary files > > may be opened for watchdog testi

Re: [PATCH v2] selftests: watchdog: Validate optional file argument

2019-09-16 Thread shuah
On 9/16/19 12:49 PM, George G. Davis wrote: As reported by Eugeniu Rosca, a side of affect of commit c3f2490d6e92 ("selftests: watchdog: Add optional file argument") is that arbitrary files may be opened for watchdog testing, e.g. You don't need to say this here since you are already have a Re

[PATCH v2] selftests: watchdog: Validate optional file argument

2019-09-16 Thread George G. Davis
As reported by Eugeniu Rosca, a side of affect of commit c3f2490d6e92 ("selftests: watchdog: Add optional file argument") is that arbitrary files may be opened for watchdog testing, e.g. ./watchdog-test -f /dev/zero Watchdog Ticking Away! To prevent watchdog-test from operating on non-watchdog d