Re: [PATCH v2] serial: rewrite pxa2xx-uart to use 8250_core

2013-12-09 Thread Sascha Hauer
On Mon, Dec 09, 2013 at 10:38:15AM +0200, Heikki Krogerus wrote: > Hi, > > > + return 0; > > + > > + err_clk: > > + clk_unprepare(data->clk); > > + err_free_clk: > > + devm_clk_put(>dev, data->clk); > > + err_free: > > + devm_kfree(>dev, data); > > And there labels could be dropped.

Re: [PATCH v2] serial: rewrite pxa2xx-uart to use 8250_core

2013-12-09 Thread Heikki Krogerus
Hi, On Fri, Dec 06, 2013 at 01:09:31PM +0400, Sergei Ianovich wrote: > pxa2xx-uart was a separate uart platform driver. It was declaring > the same device names and numbers as 8250 driver. As a result, > it was impossible to use 8250 driver on PXA SoCs. > > Upon closer examination pxa2xx-uart

Re: [PATCH v2] serial: rewrite pxa2xx-uart to use 8250_core

2013-12-09 Thread Heikki Krogerus
Hi, On Fri, Dec 06, 2013 at 01:09:31PM +0400, Sergei Ianovich wrote: pxa2xx-uart was a separate uart platform driver. It was declaring the same device names and numbers as 8250 driver. As a result, it was impossible to use 8250 driver on PXA SoCs. Upon closer examination pxa2xx-uart turned

Re: [PATCH v2] serial: rewrite pxa2xx-uart to use 8250_core

2013-12-09 Thread Sascha Hauer
On Mon, Dec 09, 2013 at 10:38:15AM +0200, Heikki Krogerus wrote: Hi, + return 0; + + err_clk: + clk_unprepare(data-clk); + err_free_clk: + devm_clk_put(pdev-dev, data-clk); + err_free: + devm_kfree(pdev-dev, data); And there labels could be dropped. This should

Re: [PATCH v2] serial: rewrite pxa2xx-uart to use 8250_core

2013-12-06 Thread James Cameron
On Fri, Dec 06, 2013 at 01:09:31PM +0400, Sergei Ianovich wrote: > pxa2xx-uart was a separate uart platform driver. It was declaring > the same device names and numbers as 8250 driver. As a result, > it was impossible to use 8250 driver on PXA SoCs. > > Upon closer examination pxa2xx-uart turned

[PATCH v2] serial: rewrite pxa2xx-uart to use 8250_core

2013-12-06 Thread Sergei Ianovich
pxa2xx-uart was a separate uart platform driver. It was declaring the same device names and numbers as 8250 driver. As a result, it was impossible to use 8250 driver on PXA SoCs. Upon closer examination pxa2xx-uart turned out to be a clone of 8250_core driver. Workaround for Erratum #19

[PATCH v2] serial: rewrite pxa2xx-uart to use 8250_core

2013-12-06 Thread Sergei Ianovich
pxa2xx-uart was a separate uart platform driver. It was declaring the same device names and numbers as 8250 driver. As a result, it was impossible to use 8250 driver on PXA SoCs. Upon closer examination pxa2xx-uart turned out to be a clone of 8250_core driver. Workaround for Erratum #19

Re: [PATCH v2] serial: rewrite pxa2xx-uart to use 8250_core

2013-12-06 Thread James Cameron
On Fri, Dec 06, 2013 at 01:09:31PM +0400, Sergei Ianovich wrote: pxa2xx-uart was a separate uart platform driver. It was declaring the same device names and numbers as 8250 driver. As a result, it was impossible to use 8250 driver on PXA SoCs. Upon closer examination pxa2xx-uart turned out