Re: [PATCH v2] slub: Do not assert not having lock in removing freed partial

2014-02-06 Thread Christoph Lameter
On Thu, 6 Feb 2014, Vladimir Davydov wrote: > > @@ -2906,12 +2916,10 @@ static void early_kmem_cache_node_alloc( > > inc_slabs_node(kmem_cache_node, node, page->objects); > > > > /* > > -* the lock is for lockdep's sake, not for any actual > > -* race protection > > +* No

Re: [PATCH v2] slub: Do not assert not having lock in removing freed partial

2014-02-06 Thread Christoph Lameter
On Thu, 6 Feb 2014, Vladimir Davydov wrote: @@ -2906,12 +2916,10 @@ static void early_kmem_cache_node_alloc( inc_slabs_node(kmem_cache_node, node, page-objects); /* -* the lock is for lockdep's sake, not for any actual -* race protection +* No locks need to be

Re: [PATCH v2] slub: Do not assert not having lock in removing freed partial

2014-02-05 Thread Vladimir Davydov
On 02/06/2014 07:21 AM, Steven Rostedt wrote: > Vladimir reported the following issue: > > Commit c65c1877bd68 ("slub: use lockdep_assert_held") requires > remove_partial() to be called with n->list_lock held, but free_partial() > called from kmem_cache_close() on cache destruction does not follow

Re: [PATCH v2] slub: Do not assert not having lock in removing freed partial

2014-02-05 Thread David Rientjes
On Wed, 5 Feb 2014, Steven Rostedt wrote: > Vladimir reported the following issue: > > Commit c65c1877bd68 ("slub: use lockdep_assert_held") requires > remove_partial() to be called with n->list_lock held, but free_partial() > called from kmem_cache_close() on cache destruction does not follow

[PATCH v2] slub: Do not assert not having lock in removing freed partial

2014-02-05 Thread Steven Rostedt
Vladimir reported the following issue: Commit c65c1877bd68 ("slub: use lockdep_assert_held") requires remove_partial() to be called with n->list_lock held, but free_partial() called from kmem_cache_close() on cache destruction does not follow this rule, leading to a warning: WARNING: CPU: 0

[PATCH v2] slub: Do not assert not having lock in removing freed partial

2014-02-05 Thread Steven Rostedt
Vladimir reported the following issue: Commit c65c1877bd68 (slub: use lockdep_assert_held) requires remove_partial() to be called with n-list_lock held, but free_partial() called from kmem_cache_close() on cache destruction does not follow this rule, leading to a warning: WARNING: CPU: 0 PID:

Re: [PATCH v2] slub: Do not assert not having lock in removing freed partial

2014-02-05 Thread David Rientjes
On Wed, 5 Feb 2014, Steven Rostedt wrote: Vladimir reported the following issue: Commit c65c1877bd68 (slub: use lockdep_assert_held) requires remove_partial() to be called with n-list_lock held, but free_partial() called from kmem_cache_close() on cache destruction does not follow this

Re: [PATCH v2] slub: Do not assert not having lock in removing freed partial

2014-02-05 Thread Vladimir Davydov
On 02/06/2014 07:21 AM, Steven Rostedt wrote: Vladimir reported the following issue: Commit c65c1877bd68 (slub: use lockdep_assert_held) requires remove_partial() to be called with n-list_lock held, but free_partial() called from kmem_cache_close() on cache destruction does not follow this