Re: [PATCH v2] slub: correctly bootstrap boot caches

2013-02-27 Thread Christoph Lameter
On Wed, 27 Feb 2013, Glauber Costa wrote: > You can apply this one as-is with Christoph's ACK. Right. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH v2] slub: correctly bootstrap boot caches

2013-02-27 Thread Glauber Costa
On 02/27/2013 11:47 AM, Pekka Enberg wrote: > On Fri, Feb 22, 2013 at 7:23 PM, Christoph Lameter wrote: >> On Fri, 22 Feb 2013, Glauber Costa wrote: >> >>> On 02/22/2013 09:01 PM, Christoph Lameter wrote: Argh. This one was the final version:

Re: [PATCH v2] slub: correctly bootstrap boot caches

2013-02-27 Thread Glauber Costa
On 02/27/2013 11:47 AM, Pekka Enberg wrote: On Fri, Feb 22, 2013 at 7:23 PM, Christoph Lameter c...@linux.com wrote: On Fri, 22 Feb 2013, Glauber Costa wrote: On 02/22/2013 09:01 PM, Christoph Lameter wrote: Argh. This one was the final version: https://patchwork.kernel.org/patch/2009521/

Re: [PATCH v2] slub: correctly bootstrap boot caches

2013-02-27 Thread Christoph Lameter
On Wed, 27 Feb 2013, Glauber Costa wrote: You can apply this one as-is with Christoph's ACK. Right. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] slub: correctly bootstrap boot caches

2013-02-26 Thread Pekka Enberg
On Fri, Feb 22, 2013 at 7:23 PM, Christoph Lameter wrote: > On Fri, 22 Feb 2013, Glauber Costa wrote: > >> On 02/22/2013 09:01 PM, Christoph Lameter wrote: >> > Argh. This one was the final version: >> > >> > https://patchwork.kernel.org/patch/2009521/ >> > >> >> It seems it would work. It is all

Re: [PATCH v2] slub: correctly bootstrap boot caches

2013-02-26 Thread Pekka Enberg
On Fri, Feb 22, 2013 at 7:23 PM, Christoph Lameter c...@linux.com wrote: On Fri, 22 Feb 2013, Glauber Costa wrote: On 02/22/2013 09:01 PM, Christoph Lameter wrote: Argh. This one was the final version: https://patchwork.kernel.org/patch/2009521/ It seems it would work. It is all the

Re: [PATCH v2] slub: correctly bootstrap boot caches

2013-02-24 Thread Joonsoo Kim
Hello, Christoph. On Sun, Feb 24, 2013 at 12:35:22AM +, Christoph Lameter wrote: > On Sat, 23 Feb 2013, JoonSoo Kim wrote: > > > With flushing, deactivate_slab() occur and it has some overhead to > > deactivate objects. > > If my patch properly fix this situation, it is better to use mine >

Re: [PATCH v2] slub: correctly bootstrap boot caches

2013-02-24 Thread Joonsoo Kim
Hello, Christoph. On Sun, Feb 24, 2013 at 12:35:22AM +, Christoph Lameter wrote: On Sat, 23 Feb 2013, JoonSoo Kim wrote: With flushing, deactivate_slab() occur and it has some overhead to deactivate objects. If my patch properly fix this situation, it is better to use mine which

Re: [PATCH v2] slub: correctly bootstrap boot caches

2013-02-23 Thread Christoph Lameter
On Sat, 23 Feb 2013, JoonSoo Kim wrote: > With flushing, deactivate_slab() occur and it has some overhead to > deactivate objects. > If my patch properly fix this situation, it is better to use mine > which has no overhead. Well this occurs during boot and its not that performance critical. --

Re: [PATCH v2] slub: correctly bootstrap boot caches

2013-02-23 Thread Christoph Lameter
On Sat, 23 Feb 2013, JoonSoo Kim wrote: With flushing, deactivate_slab() occur and it has some overhead to deactivate objects. If my patch properly fix this situation, it is better to use mine which has no overhead. Well this occurs during boot and its not that performance critical. -- To

Re: [PATCH v2] slub: correctly bootstrap boot caches

2013-02-22 Thread JoonSoo Kim
2013/2/23 Christoph Lameter : > On Fri, 22 Feb 2013, Glauber Costa wrote: > >> On 02/22/2013 09:01 PM, Christoph Lameter wrote: >> > Argh. This one was the final version: >> > >> > https://patchwork.kernel.org/patch/2009521/ >> > >> >> It seems it would work. It is all the same to me. >> Which one

Re: [PATCH v2] slub: correctly bootstrap boot caches

2013-02-22 Thread Christoph Lameter
On Fri, 22 Feb 2013, Glauber Costa wrote: > On 02/22/2013 09:01 PM, Christoph Lameter wrote: > > Argh. This one was the final version: > > > > https://patchwork.kernel.org/patch/2009521/ > > > > It seems it would work. It is all the same to me. > Which one do you prefer? Flushing seems to be

Re: [PATCH v2] slub: correctly bootstrap boot caches

2013-02-22 Thread Glauber Costa
On 02/22/2013 09:01 PM, Christoph Lameter wrote: > Argh. This one was the final version: > > https://patchwork.kernel.org/patch/2009521/ > It seems it would work. It is all the same to me. Which one do you prefer? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

Re: [PATCH v2] slub: correctly bootstrap boot caches

2013-02-22 Thread Christoph Lameter
Argh. This one was the final version: https://patchwork.kernel.org/patch/2009521/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the

Re: [PATCH v2] slub: correctly bootstrap boot caches

2013-02-22 Thread Christoph Lameter
An earlier fix to this is available here: https://patchwork.kernel.org/patch/1975301/ and https://lkml.org/lkml/2013/1/15/55 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH v2] slub: correctly bootstrap boot caches

2013-02-22 Thread Christoph Lameter
On Fri, 22 Feb 2013, Glauber Costa wrote: > After we create a boot cache, we may allocate from it until it is bootstraped. > This will move the page from the partial list to the cpu slab list. If this > happens, the loop: Acked-by: Christoph Lameter -- To unsubscribe from this list: send the

[PATCH v2] slub: correctly bootstrap boot caches

2013-02-22 Thread Glauber Costa
After we create a boot cache, we may allocate from it until it is bootstraped. This will move the page from the partial list to the cpu slab list. If this happens, the loop: list_for_each_entry(p, >partial, lru) that we use to scan for all partial pages will yield nothing, and the pages

[PATCH v2] slub: correctly bootstrap boot caches

2013-02-22 Thread Glauber Costa
After we create a boot cache, we may allocate from it until it is bootstraped. This will move the page from the partial list to the cpu slab list. If this happens, the loop: list_for_each_entry(p, n-partial, lru) that we use to scan for all partial pages will yield nothing, and the pages

Re: [PATCH v2] slub: correctly bootstrap boot caches

2013-02-22 Thread Christoph Lameter
On Fri, 22 Feb 2013, Glauber Costa wrote: After we create a boot cache, we may allocate from it until it is bootstraped. This will move the page from the partial list to the cpu slab list. If this happens, the loop: Acked-by: Christoph Lameter c...@linux.com -- To unsubscribe from this list:

Re: [PATCH v2] slub: correctly bootstrap boot caches

2013-02-22 Thread Christoph Lameter
An earlier fix to this is available here: https://patchwork.kernel.org/patch/1975301/ and https://lkml.org/lkml/2013/1/15/55 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH v2] slub: correctly bootstrap boot caches

2013-02-22 Thread Christoph Lameter
Argh. This one was the final version: https://patchwork.kernel.org/patch/2009521/ -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ

Re: [PATCH v2] slub: correctly bootstrap boot caches

2013-02-22 Thread Glauber Costa
On 02/22/2013 09:01 PM, Christoph Lameter wrote: Argh. This one was the final version: https://patchwork.kernel.org/patch/2009521/ It seems it would work. It is all the same to me. Which one do you prefer? -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the

Re: [PATCH v2] slub: correctly bootstrap boot caches

2013-02-22 Thread Christoph Lameter
On Fri, 22 Feb 2013, Glauber Costa wrote: On 02/22/2013 09:01 PM, Christoph Lameter wrote: Argh. This one was the final version: https://patchwork.kernel.org/patch/2009521/ It seems it would work. It is all the same to me. Which one do you prefer? Flushing seems to be simpler and

Re: [PATCH v2] slub: correctly bootstrap boot caches

2013-02-22 Thread JoonSoo Kim
2013/2/23 Christoph Lameter c...@linux.com: On Fri, 22 Feb 2013, Glauber Costa wrote: On 02/22/2013 09:01 PM, Christoph Lameter wrote: Argh. This one was the final version: https://patchwork.kernel.org/patch/2009521/ It seems it would work. It is all the same to me. Which one do you