Re: [PATCH v2] software_node: Add kernel-doc comments to exported symbols

2021-01-18 Thread Andy Shevchenko
On Mon, Jan 18, 2021 at 11:49:46AM +0200, Sakari Ailus wrote: > On Wed, Jan 13, 2021 at 12:02:09AM +, Daniel Scally wrote: > > + * to_software_node() - Fetch software node associated with a firmware > > node handle > > Please wrap lines over 80 (unless there's a reason to keep them longer).

Re: [PATCH v2] software_node: Add kernel-doc comments to exported symbols

2021-01-18 Thread Daniel Scally
On 18/01/2021 10:33, Andy Shevchenko wrote: > On Mon, Jan 18, 2021 at 11:49:46AM +0200, Sakari Ailus wrote: >> On Wed, Jan 13, 2021 at 12:02:09AM +, Daniel Scally wrote: >>> + * to_software_node() - Fetch software node associated with a firmware >>> node handle >> Please wrap lines over 80 (un

Re: [PATCH v2] software_node: Add kernel-doc comments to exported symbols

2021-01-18 Thread Sakari Ailus
On Mon, Jan 18, 2021 at 12:33:55PM +0200, Andy Shevchenko wrote: > On Mon, Jan 18, 2021 at 11:49:46AM +0200, Sakari Ailus wrote: > > On Wed, Jan 13, 2021 at 12:02:09AM +, Daniel Scally wrote: > > > > + * to_software_node() - Fetch software node associated with a firmware > > > node handle > >

Re: [PATCH v2] software_node: Add kernel-doc comments to exported symbols

2021-01-18 Thread Sakari Ailus
Hi Daniel, On Wed, Jan 13, 2021 at 12:02:09AM +, Daniel Scally wrote: > A number of functions which are exported via EXPORT_SYMBOL_GPL() lack any > kernel-doc comments; add those in so all exported symbols are documented. > > Reviewed-by: Andy Shevchenko > Reviewed-by: Heikki Krogerus > Sig

Re: [PATCH v2] software_node: Add kernel-doc comments to exported symbols

2021-01-14 Thread Daniel Scally
Hi Randy On 13/01/2021 01:01, Randy Dunlap wrote: > On 1/12/21 4:02 PM, Daniel Scally wrote: >> A number of functions which are exported via EXPORT_SYMBOL_GPL() lack any >> kernel-doc comments; add those in so all exported symbols are documented. >> >> Reviewed-by: Andy Shevchenko >> Reviewed-by:

Re: [PATCH v2] software_node: Add kernel-doc comments to exported symbols

2021-01-12 Thread Randy Dunlap
On 1/12/21 4:02 PM, Daniel Scally wrote: > A number of functions which are exported via EXPORT_SYMBOL_GPL() lack any > kernel-doc comments; add those in so all exported symbols are documented. > > Reviewed-by: Andy Shevchenko > Reviewed-by: Heikki Krogerus > Signed-off-by: Daniel Scally > --- >

[PATCH v2] software_node: Add kernel-doc comments to exported symbols

2021-01-12 Thread Daniel Scally
A number of functions which are exported via EXPORT_SYMBOL_GPL() lack any kernel-doc comments; add those in so all exported symbols are documented. Reviewed-by: Andy Shevchenko Reviewed-by: Heikki Krogerus Signed-off-by: Daniel Scally --- Changes in version 2: - Replaced "fwnode_handle"