Re: [Outreachy kernel] Re: [PATCH v2] staging: ks7010: remove code in comments.

2017-02-27 Thread Tobin C. Harding
On Mon, Feb 27, 2017 at 04:07:27PM +0100, Julia Lawall wrote: > > > On Mon, 27 Feb 2017, Arushi Singhal wrote: > > > > > > > On Mon, Feb 27, 2017 at 8:18 PM, Greg KH wrote: > > On Sun, Feb 26, 2017 at 09:38:20PM +0530, Arushi Singhal wrote: > > >

Re: [Outreachy kernel] Re: [PATCH v2] staging: ks7010: remove code in comments.

2017-02-27 Thread Tobin C. Harding
On Mon, Feb 27, 2017 at 04:07:27PM +0100, Julia Lawall wrote: > > > On Mon, 27 Feb 2017, Arushi Singhal wrote: > > > > > > > On Mon, Feb 27, 2017 at 8:18 PM, Greg KH wrote: > > On Sun, Feb 26, 2017 at 09:38:20PM +0530, Arushi Singhal wrote: > > > Commenting Code Is a Bad Idea. > >

Re: [Outreachy kernel] Re: [PATCH v2] staging: ks7010: remove code in comments.

2017-02-27 Thread Julia Lawall
On Mon, 27 Feb 2017, Arushi Singhal wrote: > > > On Mon, Feb 27, 2017 at 8:18 PM, Greg KH wrote: > On Sun, Feb 26, 2017 at 09:38:20PM +0530, Arushi Singhal wrote: > > Commenting Code Is a Bad Idea. > > Comments are their to explain the code and how

Re: [Outreachy kernel] Re: [PATCH v2] staging: ks7010: remove code in comments.

2017-02-27 Thread Julia Lawall
On Mon, 27 Feb 2017, Arushi Singhal wrote: > > > On Mon, Feb 27, 2017 at 8:18 PM, Greg KH wrote: > On Sun, Feb 26, 2017 at 09:38:20PM +0530, Arushi Singhal wrote: > > Commenting Code Is a Bad Idea. > > Comments are their to explain the code and how the code > achieves

Re: [PATCH v2] staging: ks7010: remove code in comments.

2017-02-27 Thread Greg KH
On Sun, Feb 26, 2017 at 09:38:20PM +0530, Arushi Singhal wrote: > Commenting Code Is a Bad Idea. > Comments are their to explain the code and how the code achieves its > goal and as codes in the comments does not explain what the code is > doing so there is no use of commenting them. > So in this

Re: [PATCH v2] staging: ks7010: remove code in comments.

2017-02-27 Thread Greg KH
On Sun, Feb 26, 2017 at 09:38:20PM +0530, Arushi Singhal wrote: > Commenting Code Is a Bad Idea. > Comments are their to explain the code and how the code achieves its > goal and as codes in the comments does not explain what the code is > doing so there is no use of commenting them. > So in this

[PATCH v2] staging: ks7010: remove code in comments.

2017-02-26 Thread Arushi Singhal
Commenting Code Is a Bad Idea. Comments are their to explain the code and how the code achieves its goal and as codes in the comments does not explain what the code is doing so there is no use of commenting them. So in this patch codes in the comments are removed. Signed-off-by: Arushi Singhal

[PATCH v2] staging: ks7010: remove code in comments.

2017-02-26 Thread Arushi Singhal
Commenting Code Is a Bad Idea. Comments are their to explain the code and how the code achieves its goal and as codes in the comments does not explain what the code is doing so there is no use of commenting them. So in this patch codes in the comments are removed. Signed-off-by: Arushi Singhal