Re: [PATCH v2] staging: mt7621-eth/ethtool.c: Correction of SPDX license identifier

2019-01-30 Thread gre...@linuxfoundation.org
On Wed, Jan 30, 2019 at 08:01:13PM +, Carlos Henrique Lima Melara wrote: > On 30/01/2019 13:29, gre...@linuxfoundation.org wrote: > > On Wed, Jan 30, 2019 at 02:48:27PM +, Carlos Henrique Lima Melara wrote: > >>This patch fix the checkpatch.p1 warning: > >> > >>WARNING: Missing or

Re: [PATCH v2] staging: mt7621-eth/ethtool.c: Correction of SPDX license identifier

2019-01-30 Thread Andrew Lunn
> See the patch about all of this from Thomas on lkml yesterday for > why this is the case. Hi Greg Thanks for the info. I had not seen this, and i guess other have not as well. So here is a link to the patch. https://lkml.org/lkml/2019/1/28/1975 Andrew

Re: [PATCH v2] staging: mt7621-eth/ethtool.c: Correction of SPDX license identifier

2019-01-30 Thread gre...@linuxfoundation.org
On Wed, Jan 30, 2019 at 05:38:17PM +0100, Andrew Lunn wrote: > On Wed, Jan 30, 2019 at 02:48:27PM +, Carlos Henrique Lima Melara wrote: > > This patch fix the checkpatch.p1 warning: > > > > WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 > > +/* > > > > It

Re: [PATCH v2] staging: mt7621-eth/ethtool.c: Correction of SPDX license identifier

2019-01-30 Thread Andrew Lunn
On Wed, Jan 30, 2019 at 02:48:27PM +, Carlos Henrique Lima Melara wrote: > This patch fix the checkpatch.p1 warning: > > WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 > +/* > > It includes the SPDX expression for GPL-2.0 and corrects the comment

Re: [PATCH v2] staging: mt7621-eth/ethtool.c: Correction of SPDX license identifier

2019-01-30 Thread gre...@linuxfoundation.org
On Wed, Jan 30, 2019 at 02:48:27PM +, Carlos Henrique Lima Melara wrote: > This patch fix the checkpatch.p1 warning: > > WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 > +/* Why did you not fix up the indentation that was already mentioned? > It