Re: [PATCH v2] staging: octeon: Fix checkpatch warnings

2014-11-28 Thread Luis de Bethencourt
On Fri, Nov 28, 2014 at 05:14:32PM +0300, Dan Carpenter wrote: > On Fri, Nov 28, 2014 at 02:30:34PM +0100, Luis de Bethencourt wrote: > > On Fri, Nov 28, 2014 at 01:29:28PM +0300, Dan Carpenter wrote: > > > On Thu, Nov 27, 2014 at 05:18:10PM +0100, Luis de Bethencourt wrote: > > > > Fixing 80 chara

Re: [PATCH v2] staging: octeon: Fix checkpatch warnings

2014-11-28 Thread Dan Carpenter
On Fri, Nov 28, 2014 at 02:30:34PM +0100, Luis de Bethencourt wrote: > On Fri, Nov 28, 2014 at 01:29:28PM +0300, Dan Carpenter wrote: > > On Thu, Nov 27, 2014 at 05:18:10PM +0100, Luis de Bethencourt wrote: > > > Fixing 80 character limit warnings in octeon/ethernet-rx.c > > > > > > Signed-off-by:

Re: [PATCH v2] staging: octeon: Fix checkpatch warnings

2014-11-28 Thread Luis de Bethencourt
On Fri, Nov 28, 2014 at 01:29:28PM +0300, Dan Carpenter wrote: > On Thu, Nov 27, 2014 at 05:18:10PM +0100, Luis de Bethencourt wrote: > > Fixing 80 character limit warnings in octeon/ethernet-rx.c > > > > Signed-off-by: Luis de Bethencourt > > --- > > drivers/staging/octeon/ethernet-rx.c | 51 >

Re: [PATCH v2] staging: octeon: Fix checkpatch warnings

2014-11-28 Thread Dan Carpenter
On Thu, Nov 27, 2014 at 05:18:10PM +0100, Luis de Bethencourt wrote: > Fixing 80 character limit warnings in octeon/ethernet-rx.c > > Signed-off-by: Luis de Bethencourt > --- > drivers/staging/octeon/ethernet-rx.c | 51 > +--- > 1 file changed, 35 insertions(+),

Re: [PATCH v2] staging: octeon: Fix checkpatch warnings

2014-11-27 Thread Luis de Bethencourt
On Thu, Nov 27, 2014 at 08:34:00AM -0800, Joe Perches wrote: > On Thu, 2014-11-27 at 17:18 +0100, Luis de Bethencourt wrote: > > Fixing 80 character limit warnings in octeon/ethernet-rx.c > > Hello again Luis. > > Another thing you might consider is to align > multiple line statements to the app

Re: [PATCH v2] staging: octeon: Fix checkpatch warnings

2014-11-27 Thread Joe Perches
On Thu, 2014-11-27 at 17:18 +0100, Luis de Bethencourt wrote: > Fixing 80 character limit warnings in octeon/ethernet-rx.c Hello again Luis. Another thing you might consider is to align multiple line statements to the appropriate open parenthesis. > diff --git a/drivers/staging/octeon/ethernet-

[PATCH v2] staging: octeon: Fix checkpatch warnings

2014-11-27 Thread Luis de Bethencourt
Fixing 80 character limit warnings in octeon/ethernet-rx.c Signed-off-by: Luis de Bethencourt --- drivers/staging/octeon/ethernet-rx.c | 51 +--- 1 file changed, 35 insertions(+), 16 deletions(-) diff --git a/drivers/staging/octeon/ethernet-rx.c b/drivers/stagin