Re: [PATCH v2] staging: rtl8188eu: remove not necessary braces {} (checkpatch fix)

2017-02-02 Thread Joe Perches
On Thu, 2017-02-02 at 08:06 +0200, Martin Karamihov wrote: > On 02/01/2017 08:11 PM, Joe Perches wrote: > > ...and clarifying the code for a > > human reader is much more important than making a > > file not have any checkpatch warnings. > > I agree. I respect the developers' own coding style and

Re: [PATCH v2] staging: rtl8188eu: remove not necessary braces {} (checkpatch fix)

2017-02-02 Thread Joe Perches
On Thu, 2017-02-02 at 08:06 +0200, Martin Karamihov wrote: > On 02/01/2017 08:11 PM, Joe Perches wrote: > > ...and clarifying the code for a > > human reader is much more important than making a > > file not have any checkpatch warnings. > > I agree. I respect the developers' own coding style and

Re: [PATCH v2] staging: rtl8188eu: remove not necessary braces {} (checkpatch fix)

2017-02-01 Thread Martin Karamihov
On 02/01/2017 08:11 PM, Joe Perches wrote: ...and clarifying the code for a human reader is much more important than making a file not have any checkpatch warnings. I agree. I respect the developers' own coding style and believe that some things (>80 characters long lines, name conventions,

Re: [PATCH v2] staging: rtl8188eu: remove not necessary braces {} (checkpatch fix)

2017-02-01 Thread Martin Karamihov
On 02/01/2017 08:11 PM, Joe Perches wrote: ...and clarifying the code for a human reader is much more important than making a file not have any checkpatch warnings. I agree. I respect the developers' own coding style and believe that some things (>80 characters long lines, name conventions,

Re: [PATCH v2] staging: rtl8188eu: remove not necessary braces {} (checkpatch fix)

2017-02-01 Thread Joe Perches
On Wed, 2017-02-01 at 18:36 +0200, Martin Karamihov wrote: > > On 02/01/2017 12:39 AM, Joe Perches wrote: > > On Tue, 2017-01-31 at 21:24 +0200, Martin Karamihov wrote: > > > This is checkpatch fix for hal/bb_cfg.c file: > > > remove not necessary braces {} > > > > > > Signed-off-by: Martin

Re: [PATCH v2] staging: rtl8188eu: remove not necessary braces {} (checkpatch fix)

2017-02-01 Thread Joe Perches
On Wed, 2017-02-01 at 18:36 +0200, Martin Karamihov wrote: > > On 02/01/2017 12:39 AM, Joe Perches wrote: > > On Tue, 2017-01-31 at 21:24 +0200, Martin Karamihov wrote: > > > This is checkpatch fix for hal/bb_cfg.c file: > > > remove not necessary braces {} > > > > > > Signed-off-by: Martin

Re: [PATCH v2] staging: rtl8188eu: remove not necessary braces {} (checkpatch fix)

2017-02-01 Thread Martin Karamihov
On 02/01/2017 12:39 AM, Joe Perches wrote: On Tue, 2017-01-31 at 21:24 +0200, Martin Karamihov wrote: This is checkpatch fix for hal/bb_cfg.c file: remove not necessary braces {} Signed-off-by: Martin Karamihov --- drivers/staging/rtl8188eu/hal/bb_cfg.c | 3 +-- 1

Re: [PATCH v2] staging: rtl8188eu: remove not necessary braces {} (checkpatch fix)

2017-02-01 Thread Martin Karamihov
On 02/01/2017 12:39 AM, Joe Perches wrote: On Tue, 2017-01-31 at 21:24 +0200, Martin Karamihov wrote: This is checkpatch fix for hal/bb_cfg.c file: remove not necessary braces {} Signed-off-by: Martin Karamihov --- drivers/staging/rtl8188eu/hal/bb_cfg.c | 3 +-- 1 file changed, 1

Re: [PATCH v2] staging: rtl8188eu: remove not necessary braces {} (checkpatch fix)

2017-01-31 Thread Joe Perches
On Tue, 2017-01-31 at 21:24 +0200, Martin Karamihov wrote: > This is checkpatch fix for hal/bb_cfg.c file: > remove not necessary braces {} > > Signed-off-by: Martin Karamihov > --- > drivers/staging/rtl8188eu/hal/bb_cfg.c | 3 +-- > 1 file changed, 1 insertion(+), 2

Re: [PATCH v2] staging: rtl8188eu: remove not necessary braces {} (checkpatch fix)

2017-01-31 Thread Joe Perches
On Tue, 2017-01-31 at 21:24 +0200, Martin Karamihov wrote: > This is checkpatch fix for hal/bb_cfg.c file: > remove not necessary braces {} > > Signed-off-by: Martin Karamihov > --- > drivers/staging/rtl8188eu/hal/bb_cfg.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff

[PATCH v2] staging: rtl8188eu: remove not necessary braces {} (checkpatch fix)

2017-01-31 Thread Martin Karamihov
This is checkpatch fix for hal/bb_cfg.c file: remove not necessary braces {} Signed-off-by: Martin Karamihov --- drivers/staging/rtl8188eu/hal/bb_cfg.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/bb_cfg.c

[PATCH v2] staging: rtl8188eu: remove not necessary braces {} (checkpatch fix)

2017-01-31 Thread Martin Karamihov
This is checkpatch fix for hal/bb_cfg.c file: remove not necessary braces {} Signed-off-by: Martin Karamihov --- drivers/staging/rtl8188eu/hal/bb_cfg.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/bb_cfg.c