Re: [PATCH v2] staging: rtl8712: fix Prefer ether_addr_copy() over memcpy()

2015-01-29 Thread Larry Finger
On 01/29/2015 04:11 PM, Heba Aamer wrote: This patch fixes the following checkpatch.pl warning: Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2) pahole showed that the struct used pnetdev->dev_addr is aligned to u16. Moreover mac is a simple array, pdata is a

[PATCH v2] staging: rtl8712: fix Prefer ether_addr_copy() over memcpy()

2015-01-29 Thread Heba Aamer
This patch fixes the following checkpatch.pl warning: Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2) pahole showed that the struct used pnetdev->dev_addr is aligned to u16. Moreover mac is a simple array, pdata is a pointer that starts from an even offset.

[PATCH v2] staging: rtl8712: fix Prefer ether_addr_copy() over memcpy()

2015-01-29 Thread Heba Aamer
This patch fixes the following checkpatch.pl warning: Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2) pahole showed that the struct used pnetdev-dev_addr is aligned to u16. Moreover mac is a simple array, pdata is a pointer that starts from an even offset.

Re: [PATCH v2] staging: rtl8712: fix Prefer ether_addr_copy() over memcpy()

2015-01-29 Thread Larry Finger
On 01/29/2015 04:11 PM, Heba Aamer wrote: This patch fixes the following checkpatch.pl warning: Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2) pahole showed that the struct used pnetdev-dev_addr is aligned to u16. Moreover mac is a simple array, pdata is a