Re: [PATCH v2] stmmac: troubleshoot unexpected bits in des0 & des1

2015-06-24 Thread Alexey Brodkin
Hi David, On Wed, 2015-06-24 at 01:44 -0700, David Miller wrote: > From: Alexey Brodkin > Date: Wed, 24 Jun 2015 11:07:26 +0300 > > > > > - priv->dma_tx = dma_alloc_coherent(priv->device, > > txsize * > > + priv->dma_tx = dma_zalloc_coherent(priv->device, > > txsize * > >

Re: [PATCH v2] stmmac: troubleshoot unexpected bits in des0 & des1

2015-06-24 Thread David Miller
From: Alexey Brodkin Date: Wed, 24 Jun 2015 11:07:26 +0300 > > - priv->dma_tx = dma_alloc_coherent(priv->device, txsize * > + priv->dma_tx = dma_zalloc_coherent(priv->device, txsize * > sizeof(struct dma_desc), >

[PATCH v2] stmmac: troubleshoot unexpected bits in des0 & des1

2015-06-24 Thread Alexey Brodkin
Current implementation of descriptor init procedure only takes care about setting/clearing ownership flag in "des0"/"des1" fields while it is perfectly possible to get unexpected bits set because of the following factors: [1] On driver probe underlying memory allocated with dma_alloc_coheren