Re: [PATCH v2] stop_machine: Disable preemption when waking two stopper threads

2018-07-02 Thread isaacm
Hi Peter, Thanks for the feedback. I'll make sure to incorporate it into my next patch, and send that soon. Thanks, Isaac Manjarres On 2018-07-02 05:15, Peter Zijlstra wrote: On Fri, Jun 29, 2018 at 01:55:12PM -0700, Isaac J. Manjarres wrote: When cpu_stop_queue_two_works() begins to wake the

Re: [PATCH v2] stop_machine: Disable preemption when waking two stopper threads

2018-07-02 Thread Peter Zijlstra
On Fri, Jun 29, 2018 at 01:55:12PM -0700, Isaac J. Manjarres wrote: > When cpu_stop_queue_two_works() begins to wake the stopper > threads, it does so without preemption disabled, which leads > to the following race condition: > > The source CPU calls cpu_stop_queue_two_works(), with cpu1 > as the

Re: [PATCH v2] stop_machine: Disable preemption when waking two stopper threads

2018-07-01 Thread Pavan Kondeti
Hi Issac, On Fri, Jun 29, 2018 at 01:55:12PM -0700, Isaac J. Manjarres wrote: > When cpu_stop_queue_two_works() begins to wake the stopper > threads, it does so without preemption disabled, which leads > to the following race condition: > > The source CPU calls cpu_stop_queue_two_works(), with cp

[PATCH v2] stop_machine: Disable preemption when waking two stopper threads

2018-06-29 Thread Isaac J. Manjarres
When cpu_stop_queue_two_works() begins to wake the stopper threads, it does so without preemption disabled, which leads to the following race condition: The source CPU calls cpu_stop_queue_two_works(), with cpu1 as the source CPU, and cpu2 as the destination CPU. When adding the stopper threads to