Re: [PATCH v2] sysrq: Use panic() to force a crash

2018-11-14 Thread Greg Kroah-Hartman
On Wed, Nov 14, 2018 at 02:57:18PM -0800, Matthias Kaehlcke wrote: > On Thu, Sep 20, 2018 at 10:12:53AM -0700, Matthias Kaehlcke wrote: > > sysrq_handle_crash() currently forces a crash by dereferencing a > > NULL pointer, which is undefined behavior in C. Just call panic() > > instead, which is si

Re: [PATCH v2] sysrq: Use panic() to force a crash

2018-11-14 Thread Matthias Kaehlcke
On Thu, Sep 20, 2018 at 10:12:53AM -0700, Matthias Kaehlcke wrote: > sysrq_handle_crash() currently forces a crash by dereferencing a > NULL pointer, which is undefined behavior in C. Just call panic() > instead, which is simpler and doesn't depend on compiler specific > handling of the undefined b

[PATCH v2] sysrq: Use panic() to force a crash

2018-09-20 Thread Matthias Kaehlcke
sysrq_handle_crash() currently forces a crash by dereferencing a NULL pointer, which is undefined behavior in C. Just call panic() instead, which is simpler and doesn't depend on compiler specific handling of the undefined behavior. Remove the comment on why the RCU lock needs to be released, it i