Re: [PATCH v2] thermal: bcm2835: Fix error code in 'bcm2835_thermal_probe'

2017-06-30 Thread Eduardo Valentin
On Fri, Jun 23, 2017 at 10:25:45PM +0200, Stefan Wahren wrote: > > > Christophe JAILLET hat am 23. Juni 2017 um > > 21:44 geschrieben: > > > > > > 'tz' is a valid pointer at this point, so calling PTR_ERR on it is > > pointless. > > This 'err = PTR_ERR(tz)'

Re: [PATCH v2] thermal: bcm2835: Fix error code in 'bcm2835_thermal_probe'

2017-06-30 Thread Eduardo Valentin
On Fri, Jun 23, 2017 at 10:25:45PM +0200, Stefan Wahren wrote: > > > Christophe JAILLET hat am 23. Juni 2017 um > > 21:44 geschrieben: > > > > > > 'tz' is a valid pointer at this point, so calling PTR_ERR on it is > > pointless. > > This 'err = PTR_ERR(tz)' looks like a cut'n'paste from a few

Re: [PATCH v2] thermal: bcm2835: Fix error code in 'bcm2835_thermal_probe'

2017-06-23 Thread Stefan Wahren
> Christophe JAILLET hat am 23. Juni 2017 um > 21:44 geschrieben: > > > 'tz' is a valid pointer at this point, so calling PTR_ERR on it is > pointless. > This 'err = PTR_ERR(tz)' looks like a cut'n'paste from a few lines above. > So remove it. 'err' is already

Re: [PATCH v2] thermal: bcm2835: Fix error code in 'bcm2835_thermal_probe'

2017-06-23 Thread Stefan Wahren
> Christophe JAILLET hat am 23. Juni 2017 um > 21:44 geschrieben: > > > 'tz' is a valid pointer at this point, so calling PTR_ERR on it is > pointless. > This 'err = PTR_ERR(tz)' looks like a cut'n'paste from a few lines above. > So remove it. 'err' is already the error we want to report. >

[PATCH v2] thermal: bcm2835: Fix error code in 'bcm2835_thermal_probe'

2017-06-23 Thread Christophe JAILLET
'tz' is a valid pointer at this point, so calling PTR_ERR on it is pointless. This 'err = PTR_ERR(tz)' looks like a cut'n'paste from a few lines above. So remove it. 'err' is already the error we want to report. Signed-off-by: Christophe JAILLET --- v2: fix empty

[PATCH v2] thermal: bcm2835: Fix error code in 'bcm2835_thermal_probe'

2017-06-23 Thread Christophe JAILLET
'tz' is a valid pointer at this point, so calling PTR_ERR on it is pointless. This 'err = PTR_ERR(tz)' looks like a cut'n'paste from a few lines above. So remove it. 'err' is already the error we want to report. Signed-off-by: Christophe JAILLET --- v2: fix empty subject ---