Re: [PATCH v2] thermal: consistently use int for temperatures

2015-07-25 Thread Pavel Machek
On Fri 2015-07-24 15:49:41, Guenter Roeck wrote: > On 07/24/2015 03:11 PM, Pavel Machek wrote: > >On Fri 2015-07-24 06:59:26, Guenter Roeck wrote: > >>On 07/23/2015 11:29 PM, Sascha Hauer wrote: > >>>On Thu, Jul 23, 2015 at 02:07:59PM +0200, Pavel Machek wrote: > On Tue 2015-07-21 09:21:32, Sas

Re: [PATCH v2] thermal: consistently use int for temperatures

2015-07-24 Thread Guenter Roeck
On 07/24/2015 03:11 PM, Pavel Machek wrote: On Fri 2015-07-24 06:59:26, Guenter Roeck wrote: On 07/23/2015 11:29 PM, Sascha Hauer wrote: On Thu, Jul 23, 2015 at 02:07:59PM +0200, Pavel Machek wrote: On Tue 2015-07-21 09:21:32, Sascha Hauer wrote: The thermal code uses int, long and unsigned l

Re: [PATCH v2] thermal: consistently use int for temperatures

2015-07-24 Thread Pavel Machek
On Fri 2015-07-24 06:59:26, Guenter Roeck wrote: > On 07/23/2015 11:29 PM, Sascha Hauer wrote: > >On Thu, Jul 23, 2015 at 02:07:59PM +0200, Pavel Machek wrote: > >>On Tue 2015-07-21 09:21:32, Sascha Hauer wrote: > >>>The thermal code uses int, long and unsigned long for temperatures > >>>in differe

Re: [PATCH v2] thermal: consistently use int for temperatures

2015-07-24 Thread Guenter Roeck
On 07/23/2015 11:29 PM, Sascha Hauer wrote: On Thu, Jul 23, 2015 at 02:07:59PM +0200, Pavel Machek wrote: On Tue 2015-07-21 09:21:32, Sascha Hauer wrote: The thermal code uses int, long and unsigned long for temperatures in different places. Using an unsigned type limits the thermal framework

Re: [PATCH v2] thermal: consistently use int for temperatures

2015-07-23 Thread Sascha Hauer
On Thu, Jul 23, 2015 at 02:07:59PM +0200, Pavel Machek wrote: > On Tue 2015-07-21 09:21:32, Sascha Hauer wrote: > > The thermal code uses int, long and unsigned long for temperatures > > in different places. > > > > Using an unsigned type limits the thermal framework to positive > > temperatures w

RE: [PATCH v2] thermal: consistently use int for temperatures

2015-07-23 Thread Zhang, Rui
.org; linux-o...@vger.kernel.org; linux-samsung- > s...@vger.kernel.org; Guenter Roeck; Rafael J. Wysocki; Maxime Ripard; > Darren Hart; lm-sens...@lm-sensors.org > Subject: Re: [PATCH v2] thermal: consistently use int for temperatures > Importance: High > > Hi Zhang, > > On

Re: [PATCH v2] thermal: consistently use int for temperatures

2015-07-23 Thread Pavel Machek
On Tue 2015-07-21 09:21:32, Sascha Hauer wrote: > The thermal code uses int, long and unsigned long for temperatures > in different places. > > Using an unsigned type limits the thermal framework to positive > temperatures without need. Also several drivers currently will report > temperatures nea

Re: [PATCH v2] thermal: consistently use int for temperatures

2015-07-23 Thread Sascha Hauer
Hi Zhang, On Tue, Jul 21, 2015 at 01:35:31PM +, Zhang, Rui wrote: > > > > Patch applied. Thanks for applying. I missed to convert another place, so we get a new compiler warning. The attached patch fixes this (suitable for git rebase --autosquash). Please let me know if you can handle this or

RE: [PATCH v2] thermal: consistently use int for temperatures

2015-07-21 Thread Zhang, Rui
n Hart; lm-sens...@lm-sensors.org > Subject: Re: [PATCH v2] thermal: consistently use int for temperatures > Importance: High > > Hi Sascha, > > Sascha Hauer writes: > > > The thermal code uses int, long and unsigned long for temperatures in > > different plac

Re: [PATCH v2] thermal: consistently use int for temperatures

2015-07-21 Thread Punit Agrawal
Hi Sascha, Sascha Hauer writes: > The thermal code uses int, long and unsigned long for temperatures > in different places. > > Using an unsigned type limits the thermal framework to positive > temperatures without need. Also several drivers currently will report > temperatures near UINT_MAX for

[PATCH v2] thermal: consistently use int for temperatures

2015-07-21 Thread Sascha Hauer
The thermal code uses int, long and unsigned long for temperatures in different places. Using an unsigned type limits the thermal framework to positive temperatures without need. Also several drivers currently will report temperatures near UINT_MAX for temperatures below 0°C. This will probably im