Re: [PATCH v2] thunderbolt: Fix to check return value of ida_simple_get

2019-03-22 Thread Mukesh Ojha
On 3/21/2019 11:19 AM, Mika Westerberg wrote: On Thu, Mar 21, 2019 at 02:09:41AM +0530, Mukesh Ojha wrote: On 3/20/2019 9:59 PM, Mika Westerberg wrote: On Wed, Mar 20, 2019 at 11:24:45AM -0500, Aditya Pakki wrote: In enumerate_services, ida_simple_get on failure can return an error and

Re: [PATCH v2] thunderbolt: Fix to check return value of ida_simple_get

2019-03-20 Thread Mika Westerberg
On Thu, Mar 21, 2019 at 02:09:41AM +0530, Mukesh Ojha wrote: > > On 3/20/2019 9:59 PM, Mika Westerberg wrote: > > On Wed, Mar 20, 2019 at 11:24:45AM -0500, Aditya Pakki wrote: > > > In enumerate_services, ida_simple_get on failure can return an error and > > > leaks memory during device_register

Re: [PATCH v2] thunderbolt: Fix to check return value of ida_simple_get

2019-03-20 Thread Mukesh Ojha
On 3/20/2019 9:59 PM, Mika Westerberg wrote: On Wed, Mar 20, 2019 at 11:24:45AM -0500, Aditya Pakki wrote: In enumerate_services, ida_simple_get on failure can return an error and leaks memory during device_register failure. The patch ensures that the dev_set_name is set on non failure cases,

Re: [PATCH v2] thunderbolt: Fix to check return value of ida_simple_get

2019-03-20 Thread Mika Westerberg
On Wed, Mar 20, 2019 at 11:24:45AM -0500, Aditya Pakki wrote: > In enumerate_services, ida_simple_get on failure can return an error and > leaks memory during device_register failure. The patch ensures that > the dev_set_name is set on non failure cases, and releases memory in > case of failure. >

[PATCH v2] thunderbolt: Fix to check return value of ida_simple_get

2019-03-20 Thread Aditya Pakki
In enumerate_services, ida_simple_get on failure can return an error and leaks memory during device_register failure. The patch ensures that the dev_set_name is set on non failure cases, and releases memory in case of failure. Signed-off-by: Aditya Pakki --- v1: Missed cleanup of svc in case of