Re: [PATCH v2] toshiba: Add correct printk log level while emitting error log

2019-08-25 Thread rishi gupta
Out of 15 contributors mentioned in driver file, 9 got invalid email domains, 6 are unresponsive. Let us keep the driver as-is for sometime more time & hope to hear from the author soon in future. Please drop v1,v2. What do you think Joe. On Mon, Aug 19, 2019 at 5:40 AM Joe Perches wrote: > > O

Re: [PATCH v2] toshiba: Add correct printk log level while emitting error log

2019-08-18 Thread Joe Perches
On Sun, 2019-08-18 at 13:04 +0530, Rishi Gupta wrote: > The printk functions are invoked without specifying required > log level when printing error messages. This commit replaces > all direct uses of printk with their corresponding pr_err/info/debug > variant. Mostly I wonder if CONFIG_TOSHIBA ne

[PATCH v2] toshiba: Add correct printk log level while emitting error log

2019-08-18 Thread Rishi Gupta
The printk functions are invoked without specifying required log level when printing error messages. This commit replaces all direct uses of printk with their corresponding pr_err/info/debug variant. Signed-off-by: Rishi Gupta --- Changes in v2: - Replaced all printk(KERN_ERR with pr_err( - Repla