Re: [PATCH v2] tpm: eventlog: Replace zero-length array with flexible-array member

2020-05-14 Thread Jarkko Sakkinen
On Wed, 2020-05-13 at 19:23 -0500, Gustavo A. R. Silva wrote: > On Thu, May 14, 2020 at 03:08:58AM +0300, Jarkko Sakkinen wrote: > > > > Signed-off-by: Gustavo A. R. Silva > > > > > > Reviewed-by: Kees Cook > > > > Thank you. > > > > I applied this patch, will include it to the next PR. > > >

Re: [PATCH v2] tpm: eventlog: Replace zero-length array with flexible-array member

2020-05-13 Thread Gustavo A. R. Silva
On Thu, May 14, 2020 at 03:08:58AM +0300, Jarkko Sakkinen wrote: > > > > > > Signed-off-by: Gustavo A. R. Silva > > > > Reviewed-by: Kees Cook > > Thank you. > > I applied this patch, will include it to the next PR. > Awesome. :) Thanks, Jarkko. -- Gustavo

Re: [PATCH v2] tpm: eventlog: Replace zero-length array with flexible-array member

2020-05-13 Thread Jarkko Sakkinen
On Mon, 2020-05-11 at 22:24 -0700, Kees Cook wrote: > On Fri, May 08, 2020 at 11:38:26AM -0500, Gustavo A. R. Silva wrote: > > The current codebase makes use of the zero-length array language > > extension to the C90 standard, but the preferred mechanism to declare > > variable-length types such as

Re: [PATCH v2] tpm: eventlog: Replace zero-length array with flexible-array member

2020-05-13 Thread Jarkko Sakkinen
On Fri, 2020-05-08 at 11:38 -0500, Gustavo A. R. Silva wrote: > The current codebase makes use of the zero-length array language > extension to the C90 standard, but the preferred mechanism to declare > variable-length types such as these ones is a flexible array member[1][2], > introduced in C99:

Re: [PATCH v2] tpm: eventlog: Replace zero-length array with flexible-array member

2020-05-12 Thread Gustavo A. R. Silva
On Mon, May 11, 2020 at 10:24:10PM -0700, Kees Cook wrote: > On Fri, May 08, 2020 at 11:38:26AM -0500, Gustavo A. R. Silva wrote: > > The current codebase makes use of the zero-length array language > > extension to the C90 standard, but the preferred mechanism to declare > > variable-length types

Re: [PATCH v2] tpm: eventlog: Replace zero-length array with flexible-array member

2020-05-11 Thread Kees Cook
On Fri, May 08, 2020 at 11:38:26AM -0500, Gustavo A. R. Silva wrote: > The current codebase makes use of the zero-length array language > extension to the C90 standard, but the preferred mechanism to declare > variable-length types such as these ones is a flexible array member[1][2], > introduced i

[PATCH v2] tpm: eventlog: Replace zero-length array with flexible-array member

2020-05-08 Thread Gustavo A. R. Silva
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99: struct foo { int stuff; struct boo array[]; }; By ma