Re: [PATCH v2] tracing/uprobes: Fix output for multiple string arguments

2019-01-17 Thread Steven Rostedt
On Thu, 17 Jan 2019 16:14:44 +0100 Andreas Ziegler wrote: > One more thing maybe, the code in question was rewritten > by Masami in 9178412ddf5a ("tracing: probeevent: Return consumed > bytes of dynamic area”) which is in v4.20 but the problem traces back > to the original commit mentioned above,

Re: [PATCH v2] tracing/uprobes: Fix output for multiple string arguments

2019-01-17 Thread Andreas Ziegler
On 17. Jan 2019, at 15:51, Steven Rostedt wrote: > > On Thu, 17 Jan 2019 15:29:09 +0100 > Andreas Ziegler wrote: > >> From my side it's basically good to go, but I just realized that there >> is no "Fixes: " tag in it but the problem it fixes goes back to >> 5baaa59ef09e ("tracing/probes: Imp

Re: [PATCH v2] tracing/uprobes: Fix output for multiple string arguments

2019-01-17 Thread Steven Rostedt
On Thu, 17 Jan 2019 15:29:09 +0100 Andreas Ziegler wrote: > From my side it's basically good to go, but I just realized that there > is no "Fixes: " tag in it but the problem it fixes goes back to > 5baaa59ef09e ("tracing/probes: Implement 'memory' fetch method for > uprobes") from 2013 (an

Re: [PATCH v2] tracing/uprobes: Fix output for multiple string arguments

2019-01-17 Thread Andreas Ziegler
On 1/17/19 3:20 PM, Steven Rostedt wrote: On Thu, 17 Jan 2019 16:58:07 +0900 Masami Hiramatsu wrote: Ah, I got it. Hmm, in that case, I have to update my patch in the previous mail. Anyway, Acked-by: Masami Hiramatsu So this patch is good to go? If so, I'll pull it in and start testing it.

Re: [PATCH v2] tracing/uprobes: Fix output for multiple string arguments

2019-01-17 Thread Steven Rostedt
On Thu, 17 Jan 2019 16:58:07 +0900 Masami Hiramatsu wrote: > Ah, I got it. > Hmm, in that case, I have to update my patch in the previous mail. > Anyway, > > Acked-by: Masami Hiramatsu So this patch is good to go? If so, I'll pull it in and start testing it. I'm currently traveling (as you pr

Re: [PATCH v2] tracing/uprobes: Fix output for multiple string arguments

2019-01-16 Thread Masami Hiramatsu
On Thu, 17 Jan 2019 08:40:05 +0100 Andreas Ziegler wrote: > On 17.01.19 07:01, Masami Hiramatsu wrote: > > On Wed, 16 Jan 2019 15:16:29 +0100 > > Andreas Ziegler wrote: > > > >> When printing multiple uprobe arguments as strings the output for the > >> earlier arguments would also include all l

Re: [PATCH v2] tracing/uprobes: Fix output for multiple string arguments

2019-01-16 Thread Andreas Ziegler
On 17.01.19 07:01, Masami Hiramatsu wrote: > On Wed, 16 Jan 2019 15:16:29 +0100 > Andreas Ziegler wrote: > >> When printing multiple uprobe arguments as strings the output for the >> earlier arguments would also include all later string arguments. >> >> This is best explained in an example: >> >>

Re: [PATCH v2] tracing/uprobes: Fix output for multiple string arguments

2019-01-16 Thread Masami Hiramatsu
On Wed, 16 Jan 2019 15:16:29 +0100 Andreas Ziegler wrote: > When printing multiple uprobe arguments as strings the output for the > earlier arguments would also include all later string arguments. > > This is best explained in an example: > > Consider adding a uprobe to a function receiving two

Re: [PATCH v2] tracing/uprobes: Fix output for multiple string arguments

2019-01-16 Thread Steven Rostedt
On Wed, 16 Jan 2019 15:16:29 +0100 Andreas Ziegler wrote: > When printing multiple uprobe arguments as strings the output for the > earlier arguments would also include all later string arguments. > > This is best explained in an example: > > Consider adding a uprobe to a function receiving two

[PATCH v2] tracing/uprobes: Fix output for multiple string arguments

2019-01-16 Thread Andreas Ziegler
When printing multiple uprobe arguments as strings the output for the earlier arguments would also include all later string arguments. This is best explained in an example: Consider adding a uprobe to a function receiving two strings as parameters which is at offset 0xa0 in strlib.so and we want