Re: [PATCH v2] tracing: Add verbose gfp_flag printing to synthetic events

2019-07-11 Thread Xing Zhengjun
Hi Tom, On 7/11/2019 11:42 PM, Tom Zanussi wrote: Hi Zhengjun, The patch itself looks fine to me, but could you please create a v3 with a couple changes to the commit message? I noticed you dropped your original commit message - please add it back and combine with part of mine, as below. Also

Re: [PATCH v2] tracing: Add verbose gfp_flag printing to synthetic events

2019-07-11 Thread Tom Zanussi
Hi Zhengjun, The patch itself looks fine to me, but could you please create a v3 with a couple changes to the commit message? I noticed you dropped your original commit message - please add it back and combine with part of mine, as below. Also, please keep your original Subject line ('[PATCH] tr

[PATCH v2] tracing: Add verbose gfp_flag printing to synthetic events

2019-07-11 Thread Zhengjun Xing
Add on top of 'trace:add "gfp_t" support in synthetic_events'. Prints the gfp flags as hex in addition to the human-readable flag string. Example output: whoopsie-630 [000] ...1 78.969452: testevent: bar=b20 (GFP_ATOMIC|__GFP_ZERO) rcuc/0-11 [000] ...1 81.097555: testevent: bar=a20 (GFP_A