Re: [PATCH v2] tracing: precise log info for kretprobe addr err

2021-01-25 Thread Steven Rostedt
On Mon, 25 Jan 2021 03:14:03 + Jianlin Lv wrote: > Hi Steven, > Could you give me more detailed suggestions about the UPROBES section? I lack > the knowledge of this part. > Can't fully understand your previous comments; Sorry for the confusion. I was talking about the MAINTAINERS file.

RE: [PATCH v2] tracing: precise log info for kretprobe addr err

2021-01-24 Thread Jianlin Lv
age- > From: Masami Hiramatsu > Sent: Sunday, January 24, 2021 4:53 PM > To: Jianlin Lv > Cc: Steven Rostedt ; mi...@redhat.com; linux- > ker...@vger.kernel.org; o...@redhat.com > Subject: Re: [PATCH v2] tracing: precise log info for kretprobe addr err > > Hi Jianlin, &g

Re: [PATCH v2] tracing: precise log info for kretprobe addr err

2021-01-24 Thread Masami Hiramatsu
Hi Jianlin, On Sat, 23 Jan 2021 14:21:48 + Jianlin Lv wrote: > Regarding the UPROBES, I read the code of trace_uprobe_create() and found a > place for improvement. > > diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c > index 3cf7128e1ad3..8c81f04d7755 100644 > ---

RE: [PATCH v2] tracing: precise log info for kretprobe addr err

2021-01-23 Thread Jianlin Lv
> -Original Message- > From: Masami Hiramatsu > Sent: Thursday, January 21, 2021 10:29 AM > To: Steven Rostedt > Cc: Jianlin Lv ; mi...@redhat.com; linux- > ker...@vger.kernel.org; Masami Hiramatsu ; > o...@redhat.com > Subject: Re: [PATCH v2] tracing: precis

Re: [PATCH v2] tracing: precise log info for kretprobe addr err

2021-01-20 Thread Masami Hiramatsu
On Wed, 20 Jan 2021 11:20:04 -0500 Steven Rostedt wrote: > > You forgot to include Masami on Cc again. Masami maintains kprobes. Please > include him on any updates, as he needs to review them, and give his > acknowledgment before acceptance. > > I need to update MAINTAINERS files to include

Re: [PATCH v2] tracing: precise log info for kretprobe addr err

2021-01-20 Thread Steven Rostedt
You forgot to include Masami on Cc again. Masami maintains kprobes. Please include him on any updates, as he needs to review them, and give his acknowledgment before acceptance. I need to update MAINTAINERS files to include trace_kprobe under KPROBES. And I also don't see any UPROBES section

[PATCH v2] tracing: precise log info for kretprobe addr err

2021-01-20 Thread Jianlin Lv
When trying to create kretprobe with the wrong function symbol in tracefs; The error is triggered in the register_trace_kprobe() and recorded as FAIL_REG_PROBE issue, Example: $ cd /sys/kernel/debug/tracing $ echo 'r:myprobe ERROR_SYMBOL_XXX ret=%x0' >> kprobe_events bash: echo: write