Re: [PATCH v2] tty: 8250: fix a missing check for pci_ioremap_bar

2019-03-24 Thread Andy Shevchenko
On Sun, Mar 24, 2019 at 2:26 PM Andy Shevchenko wrote: > On Sun, Mar 24, 2019 at 2:05 PM Andy Shevchenko > wrote: > > On Sun, Mar 24, 2019 at 12:55 AM Aditya Pakki wrote: > > > > > > pci_ioremap_bar could fail. The fix captures the failure and > > > pass an error code upstream. This can avoid

Re: [PATCH v2] tty: 8250: fix a missing check for pci_ioremap_bar

2019-03-24 Thread Andy Shevchenko
On Sun, Mar 24, 2019 at 2:05 PM Andy Shevchenko wrote: > On Sun, Mar 24, 2019 at 12:55 AM Aditya Pakki wrote: > > > > pci_ioremap_bar could fail. The fix captures the failure and > > pass an error code upstream. This can avoid potential NULL > > pointer dereferences in the future. > > > > NAK. >

Re: [PATCH v2] tty: 8250: fix a missing check for pci_ioremap_bar

2019-03-24 Thread Andy Shevchenko
On Sun, Mar 24, 2019 at 12:55 AM Aditya Pakki wrote: > > pci_ioremap_bar could fail. The fix captures the failure and > pass an error code upstream. This can avoid potential NULL > pointer dereferences in the future. > NAK. This will break non-DMA case. > Signed-off-by: Aditya Pakki > > --- >

[PATCH v2] tty: 8250: fix a missing check for pci_ioremap_bar

2019-03-23 Thread Aditya Pakki
pci_ioremap_bar could fail. The fix captures the failure and pass an error code upstream. This can avoid potential NULL pointer dereferences in the future. Signed-off-by: Aditya Pakki --- v1: Missed return by default in CONFIG_SERIAL_8250_DMA, suggested by Jiri Slaby ---