Re: [PATCH v2] tty: pl011: Work around QDF2400 E44 stuck BUSY bit

2017-02-15 Thread Timur Tabi
Christopher Covington wrote: Nothing needs QDF2400 erratum 44. Software should try to detect the presence of the erratum. So I think qdf2400_e44_detected or qdf2400_e44_present would make sense. But those suffixes don't add substantial value in my opinion. I'd be okay with qdf2400_e44_detected

Re: [PATCH v2] tty: pl011: Work around QDF2400 E44 stuck BUSY bit

2017-02-15 Thread Christopher Covington
On 2017-02-14 21:39, Timur Tabi wrote: Christopher Covington wrote: The Qualcomm Datacenter Technologies QDF2400 family of SoCs contains a custom (non-PrimeCell) implementation of the SBSA UART. Occasionally the BUSY bit in the Flag Register gets stuck as 1, erratum 44 for both 2432v1 and 2400

Re: [PATCH v2] tty: pl011: Work around QDF2400 E44 stuck BUSY bit

2017-02-15 Thread Mark Rutland
Hi, On Tue, Feb 14, 2017 at 08:39:40PM -0600, Timur Tabi wrote: > Christopher Covington wrote: > >+if (!memcmp(table->header.oem_id, "QCOM ", ACPI_OEM_ID_SIZE)) > >+if (!memcmp(table->header.oem_table_id, "QDF2432 ", > >+ACPI_OEM_TABLE_ID_SIZE) || > >

Re: [PATCH v2] tty: pl011: Work around QDF2400 E44 stuck BUSY bit

2017-02-14 Thread Timur Tabi
Christopher Covington wrote: The Qualcomm Datacenter Technologies QDF2400 family of SoCs contains a custom (non-PrimeCell) implementation of the SBSA UART. Occasionally the BUSY bit in the Flag Register gets stuck as 1, erratum 44 for both 2432v1 and 2400v1 SoCs. Checking that the Transmit FIFO E

[PATCH v2] tty: pl011: Work around QDF2400 E44 stuck BUSY bit

2017-02-14 Thread Christopher Covington
The Qualcomm Datacenter Technologies QDF2400 family of SoCs contains a custom (non-PrimeCell) implementation of the SBSA UART. Occasionally the BUSY bit in the Flag Register gets stuck as 1, erratum 44 for both 2432v1 and 2400v1 SoCs. Checking that the Transmit FIFO Empty (TXFE) bit is 0, instead o