Re: [PATCH v2] tty: serial: 8250: Fix type field in format string

2019-04-29 Thread Hao Lee
On Mon, 29 Apr 2019 at 22:31, Greg KH wrote: > This causes build warnings when applied, I'm having to drop it now. > > Please be more careful, when submitting patches, always test-build them > first. I have found my mistake. Although I have built a kernel to test my patch, I forget to turn on

Re: [PATCH v2] tty: serial: 8250: Fix type field in format string

2019-04-29 Thread Greg KH
On Sat, Apr 27, 2019 at 05:19:43PM +0800, Hao Lee wrote: > The dev_dbg statement should print the value of uart.port.mapbase instead > of its address. Besides that, uart.port.irq and uart.port.iotype are all > unsigned types, so using %u is more appropriate. > > Signed-off-by: Hao Lee > --- >

[PATCH v2] tty: serial: 8250: Fix type field in format string

2019-04-27 Thread Hao Lee
The dev_dbg statement should print the value of uart.port.mapbase instead of its address. Besides that, uart.port.irq and uart.port.iotype are all unsigned types, so using %u is more appropriate. Signed-off-by: Hao Lee --- drivers/tty/serial/8250/8250_pnp.c | 4 ++-- 1 file changed, 2