Re: [PATCH v2] ttyprintk: optimize tpk_close flush code

Hi Greg: Sorry for the late reply. > Why did you not make the change to tpk_printk() as well that I asked you > to? > > It is a static function, you control the callers, so the extra "is this > NULL, if so flush" logic makes no sense to keep around anymore, right? tpk_printk have logic to judge

Re: [PATCH v2] ttyprintk: optimize tpk_close flush code

On Tue, Nov 17, 2020 at 10:21:07AM +0800, Junyong Sun wrote: > tpk_printk(NULL,0) do nothing but call tpk_flush to > flush buffer, so why don't use tpk_flush diretcly? > this is a small optimization. > > Signed-off-by: Junyong Sun > --- > changes in v2: > - rm the flush comment as tpk_flush

[PATCH v2] ttyprintk: optimize tpk_close flush code

tpk_printk(NULL,0) do nothing but call tpk_flush to flush buffer, so why don't use tpk_flush diretcly? this is a small optimization. Signed-off-by: Junyong Sun --- changes in v2: - rm the flush comment as tpk_flush makes it obvious. --- --- drivers/char/ttyprintk.c | 3 +-- 1 file changed, 1