Re: [PATCH v2] usb: chipidea: removing of_find_property

2015-11-17 Thread Saurabh Sengar
Hi Julia, You have used v2 of patch, I have sent v3 of patch too. 1:30 hour before Please use version 3 as that is the latest. version 3 : https://lkml.org/lkml/2015/11/17/243 Sorry for trouble. Regards, Saurabh On 17 November 2015 at 18:28, Julia Lawall wrote: > Please check. The code, with

Re: [PATCH v2] usb: chipidea: removing of_find_property

2015-11-17 Thread Julia Lawall
Please check. The code, with the blank line on line 692, looks strange. julia On Tue, 17 Nov 2015, kbuild test robot wrote: > CC: kbuild-...@01.org > In-Reply-To: <1447760410-3426-1-git-send-email-saurabh.tr...@gmail.com> > TO: Saurabh Sengar > CC: m...@mansr.com, peter.c...@freescale.com,

Re: [PATCH v2] usb: chipidea: removing of_find_property

2015-11-17 Thread Måns Rullgård
Saurabh Sengar writes: > call to of_find_property() before of_property_read_u32() is unnecessary. > of_property_read_u32() anyway calls to of_find_property() only. > > Signed-off-by: Saurabh Sengar > --- > v2: removed pval variable > drivers/usb/chipidea/core.c | 61 >

[PATCH v2] usb: chipidea: removing of_find_property

2015-11-17 Thread Saurabh Sengar
call to of_find_property() before of_property_read_u32() is unnecessary. of_property_read_u32() anyway calls to of_find_property() only. Signed-off-by: Saurabh Sengar --- v2: removed pval variable drivers/usb/chipidea/core.c | 61 +++-- 1 file changed, 26

[PATCH v2] usb: chipidea: removing of_find_property

2015-11-17 Thread Saurabh Sengar
call to of_find_property() before of_property_read_u32() is unnecessary. of_property_read_u32() anyway calls to of_find_property() only. Signed-off-by: Saurabh Sengar --- v2: removed pval variable drivers/usb/chipidea/core.c | 61

Re: [PATCH v2] usb: chipidea: removing of_find_property

2015-11-17 Thread Julia Lawall
Please check. The code, with the blank line on line 692, looks strange. julia On Tue, 17 Nov 2015, kbuild test robot wrote: > CC: kbuild-...@01.org > In-Reply-To: <1447760410-3426-1-git-send-email-saurabh.tr...@gmail.com> > TO: Saurabh Sengar > CC: m...@mansr.com,

Re: [PATCH v2] usb: chipidea: removing of_find_property

2015-11-17 Thread Måns Rullgård
Saurabh Sengar writes: > call to of_find_property() before of_property_read_u32() is unnecessary. > of_property_read_u32() anyway calls to of_find_property() only. > > Signed-off-by: Saurabh Sengar > --- > v2: removed pval variable >

Re: [PATCH v2] usb: chipidea: removing of_find_property

2015-11-17 Thread Saurabh Sengar
Hi Julia, You have used v2 of patch, I have sent v3 of patch too. 1:30 hour before Please use version 3 as that is the latest. version 3 : https://lkml.org/lkml/2015/11/17/243 Sorry for trouble. Regards, Saurabh On 17 November 2015 at 18:28, Julia Lawall wrote: > Please