Re: [PATCH v2] usb: devio: Add ioctl to disallow detaching kernel USB drivers.

2016-01-25 Thread Alan Stern
On Mon, 25 Jan 2016, Bjørn Mork wrote: > Alan Stern writes: > > On Mon, 25 Jan 2016, Bjørn Mork wrote: > > > >> I don't feel much like an expert here, but I can certainly make up an > >> opinion anyway :) > >> > >> Since 64bits kernels allow usb devio with interface numbers up to 63, I > >>

Re: [PATCH v2] usb: devio: Add ioctl to disallow detaching kernel USB drivers.

2016-01-25 Thread Bjørn Mork
Alan Stern writes: > On Mon, 25 Jan 2016, Bjørn Mork wrote: > >> I don't feel much like an expert here, but I can certainly make up an >> opinion anyway :) >> >> Since 64bits kernels allow usb devio with interface numbers up to 63, I >> guess you need __u64 to avoid limiting the range? Limiting

Re: [PATCH v2] usb: devio: Add ioctl to disallow detaching kernel USB drivers.

2016-01-25 Thread Alan Stern
On Mon, 25 Jan 2016, Bjørn Mork wrote: > I don't feel much like an expert here, but I can certainly make up an > opinion anyway :) > > Since 64bits kernels allow usb devio with interface numbers up to 63, I > guess you need __u64 to avoid limiting the range? Limiting will create > all sorts of

Re: [PATCH v2] usb: devio: Add ioctl to disallow detaching kernel USB drivers.

2016-01-25 Thread Bjørn Mork
Emilio López writes: >>> diff --git a/include/uapi/linux/usbdevice_fs.h >>> b/include/uapi/linux/usbdevice_fs.h >>> index 019ba1e..9abcb34 100644 >>> --- a/include/uapi/linux/usbdevice_fs.h >>> +++ b/include/uapi/linux/usbdevice_fs.h >>> @@ -154,6 +154,10 @@ struct usbdevfs_streams { >>>

Re: [PATCH v2] usb: devio: Add ioctl to disallow detaching kernel USB drivers.

2016-01-25 Thread Alan Stern
On Mon, 25 Jan 2016, Bjørn Mork wrote: > I don't feel much like an expert here, but I can certainly make up an > opinion anyway :) > > Since 64bits kernels allow usb devio with interface numbers up to 63, I > guess you need __u64 to avoid limiting the range? Limiting will create > all sorts of

Re: [PATCH v2] usb: devio: Add ioctl to disallow detaching kernel USB drivers.

2016-01-25 Thread Bjørn Mork
Alan Stern writes: > On Mon, 25 Jan 2016, Bjørn Mork wrote: > >> I don't feel much like an expert here, but I can certainly make up an >> opinion anyway :) >> >> Since 64bits kernels allow usb devio with interface numbers up to 63, I >> guess you need __u64 to avoid

Re: [PATCH v2] usb: devio: Add ioctl to disallow detaching kernel USB drivers.

2016-01-25 Thread Alan Stern
On Mon, 25 Jan 2016, Bjørn Mork wrote: > Alan Stern writes: > > On Mon, 25 Jan 2016, Bjørn Mork wrote: > > > >> I don't feel much like an expert here, but I can certainly make up an > >> opinion anyway :) > >> > >> Since 64bits kernels allow usb devio with interface

Re: [PATCH v2] usb: devio: Add ioctl to disallow detaching kernel USB drivers.

2016-01-25 Thread Bjørn Mork
Emilio López writes: >>> diff --git a/include/uapi/linux/usbdevice_fs.h >>> b/include/uapi/linux/usbdevice_fs.h >>> index 019ba1e..9abcb34 100644 >>> --- a/include/uapi/linux/usbdevice_fs.h >>> +++ b/include/uapi/linux/usbdevice_fs.h >>> @@ -154,6 +154,10 @@ struct

Re: [PATCH v2] usb: devio: Add ioctl to disallow detaching kernel USB drivers.

2016-01-24 Thread Emilio López
Hi Alan, El 22/01/16 a las 13:10, Alan Stern escribió: On Thu, 21 Jan 2016, Emilio López wrote: From: Reilly Grant The new USBDEVFS_DROP_PRIVILEGES ioctl allows a process to voluntarily relinquish the ability to issue other ioctls that may interfere with other processes and drivers that

Re: [PATCH v2] usb: devio: Add ioctl to disallow detaching kernel USB drivers.

2016-01-24 Thread Emilio López
Hi Bjørn, El 22/01/16 a las 06:41, Bjørn Mork escribió: Emilio López writes: diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c index 38ae877c..bf40aa6 100644 --- a/drivers/usb/core/devio.c +++ b/drivers/usb/core/devio.c @@ -77,6 +77,8 @@ struct usb_dev_state { unsigned

Re: [PATCH v2] usb: devio: Add ioctl to disallow detaching kernel USB drivers.

2016-01-24 Thread Emilio López
Hi Alan, El 22/01/16 a las 13:10, Alan Stern escribió: On Thu, 21 Jan 2016, Emilio López wrote: From: Reilly Grant The new USBDEVFS_DROP_PRIVILEGES ioctl allows a process to voluntarily relinquish the ability to issue other ioctls that may interfere with other

Re: [PATCH v2] usb: devio: Add ioctl to disallow detaching kernel USB drivers.

2016-01-24 Thread Emilio López
Hi Bjørn, El 22/01/16 a las 06:41, Bjørn Mork escribió: Emilio López writes: diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c index 38ae877c..bf40aa6 100644 --- a/drivers/usb/core/devio.c +++ b/drivers/usb/core/devio.c @@ -77,6 +77,8 @@ struct

Re: [PATCH v2] usb: devio: Add ioctl to disallow detaching kernel USB drivers.

2016-01-22 Thread Alan Stern
On Thu, 21 Jan 2016, Emilio López wrote: > From: Reilly Grant > > The new USBDEVFS_DROP_PRIVILEGES ioctl allows a process to voluntarily > relinquish the ability to issue other ioctls that may interfere with > other processes and drivers that have claimed an interface on the > device. > >

Re: [PATCH v2] usb: devio: Add ioctl to disallow detaching kernel USB drivers.

2016-01-22 Thread Bjørn Mork
Emilio López writes: > diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c > index 38ae877c..bf40aa6 100644 > --- a/drivers/usb/core/devio.c > +++ b/drivers/usb/core/devio.c > @@ -77,6 +77,8 @@ struct usb_dev_state { > unsigned long ifclaimed; > u32 secid; > u32

Re: [PATCH v2] usb: devio: Add ioctl to disallow detaching kernel USB drivers.

2016-01-22 Thread Bjørn Mork
Emilio López writes: > diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c > index 38ae877c..bf40aa6 100644 > --- a/drivers/usb/core/devio.c > +++ b/drivers/usb/core/devio.c > @@ -77,6 +77,8 @@ struct usb_dev_state { > unsigned long ifclaimed; >

Re: [PATCH v2] usb: devio: Add ioctl to disallow detaching kernel USB drivers.

2016-01-22 Thread Alan Stern
On Thu, 21 Jan 2016, Emilio López wrote: > From: Reilly Grant > > The new USBDEVFS_DROP_PRIVILEGES ioctl allows a process to voluntarily > relinquish the ability to issue other ioctls that may interfere with > other processes and drivers that have claimed an interface on

[PATCH v2] usb: devio: Add ioctl to disallow detaching kernel USB drivers.

2016-01-21 Thread Emilio López
From: Reilly Grant The new USBDEVFS_DROP_PRIVILEGES ioctl allows a process to voluntarily relinquish the ability to issue other ioctls that may interfere with other processes and drivers that have claimed an interface on the device. Signed-off-by: Reilly Grant Signed-off-by: Emilio López ---

[PATCH v2] usb: devio: Add ioctl to disallow detaching kernel USB drivers.

2016-01-21 Thread Emilio López
From: Reilly Grant The new USBDEVFS_DROP_PRIVILEGES ioctl allows a process to voluntarily relinquish the ability to issue other ioctls that may interfere with other processes and drivers that have claimed an interface on the device. Signed-off-by: Reilly Grant