Hi,
On 01/15/2015 07:24 AM, Felipe Balbi wrote:
>>> This is really, really odd. Register accesses are atomic, so the
>>> lock
>>> isn't really doing anything. Besides, you're calling
>>> dwc2_is_controller_alive() from within the IRQ handler, so IRQs are
>>
Hi,
On Wed, Jan 14, 2015 at 11:04:27PM +, Paul Zimmerman wrote:
> > > > > > > > > > This is really, really odd. Register accesses are atomic,
> > > > > > > > > > so the lock
> > > > > > > > > > isn't really doing anything. Besides, you're calling
> > > > > > > > > > dwc2_is_controller_alive()
> From: Felipe Balbi [mailto:ba...@ti.com]
> Sent: Wednesday, January 14, 2015 2:50 PM
>
> On Wed, Jan 14, 2015 at 10:45:26PM +, Paul Zimmerman wrote:
> > > From: Felipe Balbi [mailto:ba...@ti.com]
> > > Sent: Wednesday, January 14, 2015 2:40 PM
> > >
> > > On Wed, Jan 14, 2015 at 10:28:54PM +
Hi,
On Wed, Jan 14, 2015 at 10:45:26PM +, Paul Zimmerman wrote:
> > From: Felipe Balbi [mailto:ba...@ti.com]
> > Sent: Wednesday, January 14, 2015 2:40 PM
> >
> > On Wed, Jan 14, 2015 at 10:28:54PM +, Paul Zimmerman wrote:
> > > > From: Felipe Balbi [mailto:ba...@ti.com]
> > > > Sent: Wed
> From: Felipe Balbi [mailto:ba...@ti.com]
> Sent: Wednesday, January 14, 2015 2:40 PM
>
> On Wed, Jan 14, 2015 at 10:28:54PM +, Paul Zimmerman wrote:
> > > From: Felipe Balbi [mailto:ba...@ti.com]
> > > Sent: Wednesday, January 14, 2015 1:46 PM
> > >
> > > On Wed, Jan 14, 2015 at 04:41:23PM -
On Wed, Jan 14, 2015 at 04:39:41PM -0600, Felipe Balbi wrote:
> On Wed, Jan 14, 2015 at 10:28:54PM +, Paul Zimmerman wrote:
> > > From: Felipe Balbi [mailto:ba...@ti.com]
> > > Sent: Wednesday, January 14, 2015 1:46 PM
> > >
> > > On Wed, Jan 14, 2015 at 04:41:23PM -0500, Alan Stern wrote:
> >
On Wed, Jan 14, 2015 at 10:28:54PM +, Paul Zimmerman wrote:
> > From: Felipe Balbi [mailto:ba...@ti.com]
> > Sent: Wednesday, January 14, 2015 1:46 PM
> >
> > On Wed, Jan 14, 2015 at 04:41:23PM -0500, Alan Stern wrote:
> > > > > > This is really, really odd. Register accesses are atomic, so th
> From: Felipe Balbi [mailto:ba...@ti.com]
> Sent: Wednesday, January 14, 2015 1:46 PM
>
> On Wed, Jan 14, 2015 at 04:41:23PM -0500, Alan Stern wrote:
> > > > > This is really, really odd. Register accesses are atomic, so the lock
> > > > > isn't really doing anything. Besides, you're calling
> >
Hi,
On Wed, Jan 14, 2015 at 04:41:23PM -0500, Alan Stern wrote:
> > > > This is really, really odd. Register accesses are atomic, so the lock
> > > > isn't really doing anything. Besides, you're calling
> > > > dwc2_is_controller_alive() from within the IRQ handler, so IRQs are
> > > > already dis
On Wed, 14 Jan 2015, Felipe Balbi wrote:
> > > This is really, really odd. Register accesses are atomic, so the lock
> > > isn't really doing anything. Besides, you're calling
> > > dwc2_is_controller_alive() from within the IRQ handler, so IRQs are
> > > already disabled.
> >
> > Spinlocks somet
Hi,
On Wed, Jan 14, 2015 at 03:06:39PM -0500, Alan Stern wrote:
> > > This patch fixes bug described here:
> > > https://lkml.org/lkml/2014/12/22/185
> > >
> > > Signed-off-by: Robert Baldyga
> > > ---
> > >
> > > Changelog:
> > >
> > > v2:
> > > - fixed comment from Paul Zimmerman
> > >
> >
On Wed, 14 Jan 2015, Felipe Balbi wrote:
> On Wed, Jan 14, 2015 at 07:45:31AM +0100, Robert Baldyga wrote:
> > This patch fixes bug described here:
> > https://lkml.org/lkml/2014/12/22/185
> >
> > Signed-off-by: Robert Baldyga
> > ---
> >
> > Changelog:
> >
> > v2:
> > - fixed comment from Pau
On Wed, Jan 14, 2015 at 07:45:31AM +0100, Robert Baldyga wrote:
> This patch fixes bug described here:
> https://lkml.org/lkml/2014/12/22/185
>
> Signed-off-by: Robert Baldyga
> ---
>
> Changelog:
>
> v2:
> - fixed comment from Paul Zimmerman
>
> v1: https://lkml.org/lkml/2015/1/13/186
>
> d
> From: Robert Baldyga [mailto:r.bald...@samsung.com]
> Sent: Tuesday, January 13, 2015 10:46 PM
>
> This patch fixes bug described here:
> https://lkml.org/lkml/2014/12/22/185
>
> Signed-off-by: Robert Baldyga
Although I don't understand *why* this fixes Robert's issue, it's
certainly a harmle
This patch fixes bug described here:
https://lkml.org/lkml/2014/12/22/185
Signed-off-by: Robert Baldyga
---
Changelog:
v2:
- fixed comment from Paul Zimmerman
v1: https://lkml.org/lkml/2015/1/13/186
drivers/usb/dwc2/core_intr.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
dif
15 matches
Mail list logo