RE: [PATCH v2] usb: ehci-s5p: Use devm for requesting ehci_vbus_gpio

2013-03-25 Thread Kukjin Kim
Doug Anderson wrote: > > The ehci_vbus_gpio is requested but never freed. This can cause > problems with deferred probes and would cause problems if > s5p_ehci_remove was ever called. Use devm to fix this. > > Signed-off-by: Doug Anderson Acked-by: Kukjin Kim Thanks. - Kukjin > --- >

RE: [PATCH v2] usb: ehci-s5p: Use devm for requesting ehci_vbus_gpio

2013-03-25 Thread Kukjin Kim
Doug Anderson wrote: The ehci_vbus_gpio is requested but never freed. This can cause problems with deferred probes and would cause problems if s5p_ehci_remove was ever called. Use devm to fix this. Signed-off-by: Doug Anderson diand...@chromium.org Acked-by: Kukjin Kim

Re: [PATCH v2] usb: ehci-s5p: Use devm for requesting ehci_vbus_gpio

2013-03-18 Thread Vivek Gautam
Hi, On Fri, Mar 15, 2013 at 8:58 AM, Jingoo Han wrote: > On Friday, March 15, 2013 12:16 PM, Doug Anderson wrote: >> >> The ehci_vbus_gpio is requested but never freed. This can cause >> problems with deferred probes and would cause problems if >> s5p_ehci_remove was ever called. Use devm to

Re: [PATCH v2] usb: ehci-s5p: Use devm for requesting ehci_vbus_gpio

2013-03-18 Thread Vivek Gautam
Hi, On Fri, Mar 15, 2013 at 8:58 AM, Jingoo Han jg1@samsung.com wrote: On Friday, March 15, 2013 12:16 PM, Doug Anderson wrote: The ehci_vbus_gpio is requested but never freed. This can cause problems with deferred probes and would cause problems if s5p_ehci_remove was ever called.

Re: [PATCH v2] usb: ehci-s5p: Use devm for requesting ehci_vbus_gpio

2013-03-14 Thread Jingoo Han
On Friday, March 15, 2013 12:16 PM, Doug Anderson wrote: > > The ehci_vbus_gpio is requested but never freed. This can cause > problems with deferred probes and would cause problems if > s5p_ehci_remove was ever called. Use devm to fix this. > > Signed-off-by: Doug Anderson Acked-by: Jingoo

[PATCH v2] usb: ehci-s5p: Use devm for requesting ehci_vbus_gpio

2013-03-14 Thread Doug Anderson
The ehci_vbus_gpio is requested but never freed. This can cause problems with deferred probes and would cause problems if s5p_ehci_remove was ever called. Use devm to fix this. Signed-off-by: Doug Anderson --- Changes in v2: - >dev => dev elsewhere in s5p_setup_vbus_gpio()

[PATCH v2] usb: ehci-s5p: Use devm for requesting ehci_vbus_gpio

2013-03-14 Thread Doug Anderson
The ehci_vbus_gpio is requested but never freed. This can cause problems with deferred probes and would cause problems if s5p_ehci_remove was ever called. Use devm to fix this. Signed-off-by: Doug Anderson diand...@chromium.org --- Changes in v2: - pdev-dev = dev elsewhere in

Re: [PATCH v2] usb: ehci-s5p: Use devm for requesting ehci_vbus_gpio

2013-03-14 Thread Jingoo Han
On Friday, March 15, 2013 12:16 PM, Doug Anderson wrote: The ehci_vbus_gpio is requested but never freed. This can cause problems with deferred probes and would cause problems if s5p_ehci_remove was ever called. Use devm to fix this. Signed-off-by: Doug Anderson diand...@chromium.org