RE: [PATCH v2] usb: host: xhci-plat: fix support for XHCI_SKIP_PHY_INIT quirk

2021-02-01 Thread Yoshihiro Shimoda
> From: Pali Rohár, Sent: Tuesday, February 2, 2021 12:12 AM > On Tuesday 26 January 2021 10:06:06 Pali Rohár wrote: > > On Tuesday 26 January 2021 04:27:37 Yoshihiro Shimoda wrote: > > > Hi Pali, > > > > > I can see the benefit in this. > > > > > In the xhci-plat case usb_create_hcd and

Re: [PATCH v2] usb: host: xhci-plat: fix support for XHCI_SKIP_PHY_INIT quirk

2021-02-01 Thread Pali Rohár
On Tuesday 26 January 2021 10:06:06 Pali Rohár wrote: > On Tuesday 26 January 2021 04:27:37 Yoshihiro Shimoda wrote: > > Hi Pali, > > > > I can see the benefit in this. > > > > In the xhci-plat case usb_create_hcd and usb_add_hcd are separate > > > > steps, and > > > > we could both copy the

Re: [PATCH v2] usb: host: xhci-plat: fix support for XHCI_SKIP_PHY_INIT quirk

2021-01-26 Thread Pali Rohár
On Tuesday 26 January 2021 04:27:37 Yoshihiro Shimoda wrote: > Hi Pali, > > > From: Pali Rohár, Sent: Monday, January 25, 2021 11:20 PM > > On Friday 15 January 2021 15:32:30 Mathias Nyman wrote: > > > On 14.1.2021 1.20, Pali Rohár wrote: > > > > On Thursday 24 December 2020 05:59:05 Peter Chen

RE: [PATCH v2] usb: host: xhci-plat: fix support for XHCI_SKIP_PHY_INIT quirk

2021-01-26 Thread Yoshihiro Shimoda
Hi Pali, > From: Pali Rohár, Sent: Monday, January 25, 2021 11:20 PM > On Friday 15 January 2021 15:32:30 Mathias Nyman wrote: > > On 14.1.2021 1.20, Pali Rohár wrote: > > > On Thursday 24 December 2020 05:59:05 Peter Chen wrote: > > >> On 20-12-23 17:18:47, Pali Rohár wrote: > > >>> Currently

Re: [PATCH v2] usb: host: xhci-plat: fix support for XHCI_SKIP_PHY_INIT quirk

2021-01-25 Thread Pali Rohár
On Friday 15 January 2021 15:32:30 Mathias Nyman wrote: > On 14.1.2021 1.20, Pali Rohár wrote: > > On Thursday 24 December 2020 05:59:05 Peter Chen wrote: > >> On 20-12-23 17:18:47, Pali Rohár wrote: > >>> Currently init_quirk callbacks for xhci platform drivers are called > >>> xhci_plat_setup()

Re: [PATCH v2] usb: host: xhci-plat: fix support for XHCI_SKIP_PHY_INIT quirk

2021-01-15 Thread Mathias Nyman
On 14.1.2021 1.20, Pali Rohár wrote: > On Thursday 24 December 2020 05:59:05 Peter Chen wrote: >> On 20-12-23 17:18:47, Pali Rohár wrote: >>> Currently init_quirk callbacks for xhci platform drivers are called >>> xhci_plat_setup() function which is called after chip reset completes. >>> It

Re: [PATCH v2] usb: host: xhci-plat: fix support for XHCI_SKIP_PHY_INIT quirk

2021-01-13 Thread Pali Rohár
On Thursday 24 December 2020 05:59:05 Peter Chen wrote: > On 20-12-23 17:18:47, Pali Rohár wrote: > > Currently init_quirk callbacks for xhci platform drivers are called > > xhci_plat_setup() function which is called after chip reset completes. > > It happens in the middle of the usb_add_hcd()

Re: [PATCH v2] usb: host: xhci-plat: fix support for XHCI_SKIP_PHY_INIT quirk

2020-12-23 Thread Peter Chen
On 20-12-23 17:18:47, Pali Rohár wrote: > Currently init_quirk callbacks for xhci platform drivers are called > xhci_plat_setup() function which is called after chip reset completes. > It happens in the middle of the usb_add_hcd() function. > > But XHCI_SKIP_PHY_INIT quirk is checked in the

[PATCH v2] usb: host: xhci-plat: fix support for XHCI_SKIP_PHY_INIT quirk

2020-12-23 Thread Pali Rohár
Currently init_quirk callbacks for xhci platform drivers are called xhci_plat_setup() function which is called after chip reset completes. It happens in the middle of the usb_add_hcd() function. But XHCI_SKIP_PHY_INIT quirk is checked in the xhci_plat_probe() function prior calling usb_add_hcd()