Re: [PATCH v2] usb: typec: tcpm: turn tcpm_ams_finish into void function

2021-03-08 Thread Guenter Roeck
On Mon, Mar 08, 2021 at 02:35:30PM +0800, Yang Li wrote: > This function always return '0' and no callers use the return value. > So make it a void function. > > This eliminates the following coccicheck warning: > ./drivers/usb/typec/tcpm/tcpm.c:778:5-8: Unneeded variable: "ret". > Return "0" on

Re: [PATCH v2] usb: typec: tcpm: turn tcpm_ams_finish into void function

2021-03-08 Thread Heikki Krogerus
On Mon, Mar 08, 2021 at 02:35:30PM +0800, Yang Li wrote: > This function always return '0' and no callers use the return value. > So make it a void function. > > This eliminates the following coccicheck warning: > ./drivers/usb/typec/tcpm/tcpm.c:778:5-8: Unneeded variable: "ret". > Return "0" on

[PATCH v2] usb: typec: tcpm: turn tcpm_ams_finish into void function

2021-03-07 Thread Yang Li
This function always return '0' and no callers use the return value. So make it a void function. This eliminates the following coccicheck warning: ./drivers/usb/typec/tcpm/tcpm.c:778:5-8: Unneeded variable: "ret". Return "0" on line 794 Reported-by: Abaci Robot Signed-off-by: Yang Li ---