Re: [PATCH v2] vfio/pci: Mask buggy SR-IOV VF INTx support

2018-09-21 Thread Alex Williamson
On Thu, 20 Sep 2018 22:53:04 -0700 Christoph Hellwig wrote: > > +/* > > + * Nag about hardware bugs, hopefully to have vendors fix them, but at > > least > > + * to collect a list of dependencies for the VF INTx pin quirk below. > > + */ > > +static const struct pci_device_id

Re: [PATCH v2] vfio/pci: Mask buggy SR-IOV VF INTx support

2018-09-21 Thread Alex Williamson
On Thu, 20 Sep 2018 22:53:04 -0700 Christoph Hellwig wrote: > > +/* > > + * Nag about hardware bugs, hopefully to have vendors fix them, but at > > least > > + * to collect a list of dependencies for the VF INTx pin quirk below. > > + */ > > +static const struct pci_device_id

Re: [PATCH v2] vfio/pci: Mask buggy SR-IOV VF INTx support

2018-09-20 Thread Christoph Hellwig
> +/* > + * Nag about hardware bugs, hopefully to have vendors fix them, but at least > + * to collect a list of dependencies for the VF INTx pin quirk below. > + */ > +static const struct pci_device_id known_bogus_vf_intx_pin[] = { > + { PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x270c) }, > + {} >

Re: [PATCH v2] vfio/pci: Mask buggy SR-IOV VF INTx support

2018-09-20 Thread Christoph Hellwig
> +/* > + * Nag about hardware bugs, hopefully to have vendors fix them, but at least > + * to collect a list of dependencies for the VF INTx pin quirk below. > + */ > +static const struct pci_device_id known_bogus_vf_intx_pin[] = { > + { PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x270c) }, > + {} >

Re: [PATCH v2] vfio/pci: Mask buggy SR-IOV VF INTx support

2018-09-20 Thread Raj, Ashok
On Thu, Sep 20, 2018 at 03:56:41PM -0700, Eads, Gage wrote: Thanks Gage. > Hi Alex, > > > > Known devices with this issue: 8086:270c > > > > Signed-off-by: Alex Williamson > > Tested-by: Gage Eads Reviewed-by: Ashok Raj

Re: [PATCH v2] vfio/pci: Mask buggy SR-IOV VF INTx support

2018-09-20 Thread Raj, Ashok
On Thu, Sep 20, 2018 at 03:56:41PM -0700, Eads, Gage wrote: Thanks Gage. > Hi Alex, > > > > Known devices with this issue: 8086:270c > > > > Signed-off-by: Alex Williamson > > Tested-by: Gage Eads Reviewed-by: Ashok Raj

RE: [PATCH v2] vfio/pci: Mask buggy SR-IOV VF INTx support

2018-09-20 Thread Eads, Gage
0, 2018 3:03 PM > To: k...@vger.kernel.org; Raj, Ashok ; Eads, Gage > > Cc: gno...@lxorguk.ukuu.org.uk; linux-kernel@vger.kernel.org > Subject: [PATCH v2] vfio/pci: Mask buggy SR-IOV VF INTx support > > The SR-IOV spec requires that VFs must report zero for the INTx pin registe

RE: [PATCH v2] vfio/pci: Mask buggy SR-IOV VF INTx support

2018-09-20 Thread Eads, Gage
0, 2018 3:03 PM > To: k...@vger.kernel.org; Raj, Ashok ; Eads, Gage > > Cc: gno...@lxorguk.ukuu.org.uk; linux-kernel@vger.kernel.org > Subject: [PATCH v2] vfio/pci: Mask buggy SR-IOV VF INTx support > > The SR-IOV spec requires that VFs must report zero for the INTx pin registe

[PATCH v2] vfio/pci: Mask buggy SR-IOV VF INTx support

2018-09-20 Thread Alex Williamson
The SR-IOV spec requires that VFs must report zero for the INTx pin register as VFs are precluded from INTx support. It's much easier for the host kernel to understand whether a device is a VF and therefore whether a non-zero pin register value is bogus than it is to do the same in userspace.

[PATCH v2] vfio/pci: Mask buggy SR-IOV VF INTx support

2018-09-20 Thread Alex Williamson
The SR-IOV spec requires that VFs must report zero for the INTx pin register as VFs are precluded from INTx support. It's much easier for the host kernel to understand whether a device is a VF and therefore whether a non-zero pin register value is bogus than it is to do the same in userspace.