Re: [PATCH v2] vhost/vsock: specify module version

2024-10-02 Thread Jakub Kicinski
On Mon, 30 Sep 2024 19:03:52 +0200 Aleksandr Mikhalitsyn wrote: > > At this point my question is, should we solve the problem higher and > > show all the modules in /sys/modules, either way? > > Probably, yes. We can ask Luis Chamberlain's opinion on this one. > > +cc Luis Chamberlain > > > >

Re: [PATCH v2] vhost/vsock: specify module version

2024-09-30 Thread Andrew Lunn
> > >Hi Stefano, > > > > > >> > > >> I was looking at other commits to see how versioning is handled in order > > >> to make sense (e.g. using the same version of the kernel), and I saw > > >> many commits that are removing MODULE_VERSION because they say it > > >> doesn't make sense in in-tree mod

Re: [PATCH v2] vhost/vsock: specify module version

2024-09-30 Thread Aleksandr Mikhalitsyn
On Mon, Sep 30, 2024 at 5:43 PM Stefano Garzarella wrote: > > Hi Aleksandr, > > On Mon, Sep 30, 2024 at 04:43:36PM GMT, Aleksandr Mikhalitsyn wrote: > >On Mon, Sep 30, 2024 at 4:27 PM Stefano Garzarella > > wrote: > >> > >> On Sun, Sep 29, 2024 at 08:21:03PM GMT, Alexander Mikhalitsyn wrote: > >>

Re: [PATCH v2] vhost/vsock: specify module version

2024-09-30 Thread Stefano Garzarella
Hi Aleksandr, On Mon, Sep 30, 2024 at 04:43:36PM GMT, Aleksandr Mikhalitsyn wrote: On Mon, Sep 30, 2024 at 4:27 PM Stefano Garzarella wrote: On Sun, Sep 29, 2024 at 08:21:03PM GMT, Alexander Mikhalitsyn wrote: >Add an explicit MODULE_VERSION("0.0.1") specification for the vhost_vsock module.

Re: [PATCH v2] vhost/vsock: specify module version

2024-09-30 Thread Aleksandr Mikhalitsyn
On Mon, Sep 30, 2024 at 4:27 PM Stefano Garzarella wrote: > > On Sun, Sep 29, 2024 at 08:21:03PM GMT, Alexander Mikhalitsyn wrote: > >Add an explicit MODULE_VERSION("0.0.1") specification for the vhost_vsock > >module. > > > >It is useful because it allows userspace to check if vhost_vsock is the

Re: [PATCH v2] vhost/vsock: specify module version

2024-09-30 Thread Aleksandr Mikhalitsyn
On Mon, Sep 30, 2024 at 4:05 PM Michael S. Tsirkin wrote: > > On Mon, Sep 30, 2024 at 02:28:30PM +0200, Aleksandr Mikhalitsyn wrote: > > On Sun, Sep 29, 2024 at 9:03 PM Michael S. Tsirkin wrote: > > > > > > On Sun, Sep 29, 2024 at 08:21:03PM +0200, Alexander Mikhalitsyn wrote: > > > > Add an expl

Re: [PATCH v2] vhost/vsock: specify module version

2024-09-30 Thread Stefano Garzarella
On Sun, Sep 29, 2024 at 08:21:03PM GMT, Alexander Mikhalitsyn wrote: Add an explicit MODULE_VERSION("0.0.1") specification for the vhost_vsock module. It is useful because it allows userspace to check if vhost_vsock is there when it is configured as a built-in. This is what we have *without*

Re: [PATCH v2] vhost/vsock: specify module version

2024-09-30 Thread Michael S. Tsirkin
On Mon, Sep 30, 2024 at 02:28:30PM +0200, Aleksandr Mikhalitsyn wrote: > On Sun, Sep 29, 2024 at 9:03 PM Michael S. Tsirkin wrote: > > > > On Sun, Sep 29, 2024 at 08:21:03PM +0200, Alexander Mikhalitsyn wrote: > > > Add an explicit MODULE_VERSION("0.0.1") specification for the vhost_vsock > > > m

Re: [PATCH v2] vhost/vsock: specify module version

2024-09-30 Thread Aleksandr Mikhalitsyn
On Sun, Sep 29, 2024 at 9:03 PM Michael S. Tsirkin wrote: > > On Sun, Sep 29, 2024 at 08:21:03PM +0200, Alexander Mikhalitsyn wrote: > > Add an explicit MODULE_VERSION("0.0.1") specification for the vhost_vsock > > module. > > > > It is useful because it allows userspace to check if vhost_vsock i

Re: [PATCH v2] vhost/vsock: specify module version

2024-09-29 Thread Michael S. Tsirkin
On Sun, Sep 29, 2024 at 08:21:03PM +0200, Alexander Mikhalitsyn wrote: > Add an explicit MODULE_VERSION("0.0.1") specification for the vhost_vsock > module. > > It is useful because it allows userspace to check if vhost_vsock is there > when it is > configured as a built-in. > > This is what we

[PATCH v2] vhost/vsock: specify module version

2024-09-29 Thread Alexander Mikhalitsyn
Add an explicit MODULE_VERSION("0.0.1") specification for the vhost_vsock module. It is useful because it allows userspace to check if vhost_vsock is there when it is configured as a built-in. This is what we have *without* this change and when vhost_vsock is configured as a module and loaded: