From: Florian Zumbiehl
Date: Mon, 8 Oct 2012 21:19:44 +0200
> The only way to reach the new check without another_round and with a
> non-zero tag is the first return false, which happens if there is no device
> for the tag, in which case setting PACKET_OTHERHOST should be the right
> thing to do
Hi,
> But I wonder if it breaks things, since you do the assignment so late
> we no longer handle the case where the VLAN device's MAC address
> matches the packet MAC address and the top-level device's does not.
>
> That's handled by logic in vlan_do_receive() which checks for
> PACKET_OTHERHOST
From: Florian Zumbiehl
Date: Mon, 8 Oct 2012 03:51:58 +0200
> This version completely avoids any new state that could need to be spilled
> to RAM, and instead re-checks existence and non-zeroness of the tag. What
> do you think?
At a high level it looks fine and doesn't have the problems mention
6a32e4f9dd9219261f8856f817e6655114cfec2f made the vlan code skip marking
vlan-tagged frames for not locally configured vlans as PACKET_OTHERHOST if
there was an rx_handler, as the rx_handler could cause the frame to be received
on a different (virtual) vlan-capable interface where that vlan might b
4 matches
Mail list logo
